Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Nondeterministic #169

Closed
wants to merge 2 commits into from
Closed

Fix Nondeterministic #169

wants to merge 2 commits into from

Conversation

ju-w
Copy link
Contributor

@ju-w ju-w commented Nov 10, 2023

An easy workaround to fix #168

@ju-w ju-w deleted the branch vislearn:master March 18, 2024 14:03
@ju-w ju-w closed this Mar 18, 2024
@ju-w ju-w deleted the master branch March 18, 2024 14:03
@ju-w ju-w restored the master branch March 18, 2024 14:24
@ju-w ju-w reopened this Mar 18, 2024
@fdraxler
Copy link
Collaborator

Hi,

thanks debugging this issue and proposing a fix! I have one concern though: Even if the execution order in the graph is not ambiguous (due to only sequential nodes), but existing code did not pass the right order of nodes to the GraphINN, then existing checkpoints would break. Would you agree that using a defaultset(list) in

edges_in_to_out = defaultdict(set)

would also yield a deterministic order?

Best! Felix

@ju-w
Copy link
Contributor Author

ju-w commented Mar 19, 2024

Hi!
This is by no means supposed to be an ideal solution, just one that fixed my particular issue. I don't really have the patience or time to dig into potential corner cases, so please feel free to redo this as you please!

@ju-w
Copy link
Contributor Author

ju-w commented Mar 19, 2024

This was merely supposed to be a workaround, but as you are now aware of the problem and actively working on it, I will close this PR.

@ju-w ju-w closed this Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Nondeterministic
2 participants