Give some love to the project #150
Conversation
guizmaii
commented
Jan 9, 2025
•
guizmaii
commented
- update Scala versions
- update dependencies
- update sbt
- update sbt plugins
- remove usage of some deprecated methods
- remove some compilation warnings
| @@ -39,7 +41,7 @@ val publishSettings = Seq( | |||
| id = "vitaliihonta", | |||
| name = "Vitalii Honta", | |||
| email = "[email protected]", | |||
| url = new URL("https://github.com/vitaliihonta") | |||
There was a problem hiding this comment.
Was emitting a deprecation warning
| @@ -4,6 +4,6 @@ trait ZSearchAttributeMetaEnumInstances { | |||
|
|
|||
| /** Provides an attribute meta for old [[scala.Enumeration]] | |||
| */ | |||
| def enumeration(enum: Enumeration): ZSearchAttributeMeta.Of[enum.Value, ZSearchAttribute.Keyword, String] = | |||
| new ZSearchAttributeMeta.KeywordMeta[enum.Value](_.toString, raw => enum.withName(raw)) | |||
| def enumeration(`enum`: Enumeration): ZSearchAttributeMeta.Of[`enum`.Value, ZSearchAttribute.Keyword, String] = | |||
There was a problem hiding this comment.
Was emitting a warning telling that enum will be a reserved keyword in Scala3 and should be replaced with a backticked name
| @@ -156,34 +156,34 @@ object ZSearchAttributeMeta extends ZSearchAttributeMetaCollectionInstances with | |||
| override def decode(value: A): A = value | |||
| } | |||
|
|
|||
| private final object StringMeta extends SimplePlainMeta[String] { | |||
There was a problem hiding this comment.
Was emitting a warning saying that the final is redundant
| @@ -226,7 +226,7 @@ object ZAsync { | |||
| )(f: A => ZAsync[B] | |||
| )(implicit bf: BuildFrom[Collection[A], B, Collection[B]] | |||
| ): ZAsync[Collection[B]] = | |||
| in.foldLeft[ZAsync[mutable.Builder[B, Collection[B]]]](succeed(bf(in)))((acc, a) => acc.zipWith(f(a))(_ += _)) | |||
There was a problem hiding this comment.
Builder.apply is deprecated in favour of Builder.newBuilder
| @@ -215,21 +215,21 @@ object ZSaga { | |||
|
|
|||
| def interpret[A0](saga: ZSaga[A0]): Either[Throwable, A0] = | |||
| saga match { | |||
| case succeed: Succeed[A0] => Right(succeed.value) | |||
There was a problem hiding this comment.
Was emitting a warning as the program is not able to type check the A0 type as it's eliminated at runtime
| temporalSaga.addCompensation((() => compensation.compensate()): Proc) | ||
| interpret(compensation.cont) | ||
|
|
||
| case cont: Bind[baseA, A0] => |
| @@ -35,6 +35,6 @@ class ZioLocalWorkflowImpl extends ZioLocalWorkflow { | |||
|
|
|||
| override def complete(): Unit = { | |||
| logger.info("Completion received!") | |||
| state := () | |||
There was a problem hiding this comment.
Was emitting a warning saying that this syntax was deprecated
guizmaii
force-pushed
the
updates
branch
3 times, most recently
from
c8d9122 to
8dfb458
Compare
| scalaVersion := scala213, | ||
| crossScalaVersions := allScalaVersions, |
There was a problem hiding this comment.
Added this because the scala version used by default in each module was a bit chaotic.
You can see that by running sbt 'show scalaVersion'
guizmaii
force-pushed
the
updates
branch
2 times, most recently
from
5107e10 to
8bb00b1
Compare
- update Scala versions - update dependencies - update sbt - update sbt plugins - remove usage of some deprecated methods - remove some compilation warnings
|
@guizmaii thank you so much for contributing ❤️ |
