fix: respect top-level server.preTransformRequests
#19272
+99
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hi-ogawa
force-pushed
the
fix-server-preTransformRequests-compat
branch
from
5c35f99 to
97d7f6e
Compare
hi-ogawa
changed the title
server.preTransformRequestsserver.preTransformRequests
hi-ogawa
changed the title
server.preTransformRequestspreTransformRequests
hi-ogawa
changed the title
preTransformRequestsserver.preTransformRequests
commit: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It looks like there were two changes related to
preTransformRequestson Vite 6, namely:server.preTransformRequestshas no effect onenvironment.dev.preTransformRequests.server.preTransformRequests: trueby default both on client and ssr on Vite 5, now only client environmentdev.preTransformRequests: trueand ssr does not pre transform by default.I made a reproduction in https://github.com/hi-ogawa/reproductions/tree/main/vitest-7345-preTransformRequests-false.
I assume the first one is a bug since currently
server.preTransformRequestsis no-op and we should either deprecate/remove or use it as a default. This is what this PR addresses and I confirmed this fixed Vitest's issue https://stackblitz.com/edit/bolt-vue-7wha3d5d?file=package.json. There are also some usages in the wild https://github.com/search?q=preTransformRequests&type=code.For the 2nd one, I wasn't aware of this change and I'm not sure if it's intended. I'll leave this part out of the PR for now.