Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VALUES statement AST and parsing #17500

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

VALUES statement AST and parsing #17500

wants to merge 6 commits into from

Conversation

harshit-gangal
Copy link
Member

@harshit-gangal harshit-gangal commented Jan 9, 2025 •
edited by systay
Loading

Description

This PR cherry picks the commit from #16703.

  • SQL parsing support for VALUES statements
mysql> VALUES ROW(1,2), ROW(2,3);
+----------+----------+
| column_0 | column_1 |
+----------+----------+
|        1 |        2 |
|        2 |        3 |
+----------+----------+
2 rows in set (0.00 sec)

Related Issue(s)

Checklist

  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

harshit-gangal and others added 4 commits January 9, 2025 23:04
@harshit-gangal
feat: added values statement to ast
eccceb3 
Signed-off-by: Harshit Gangal <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
@harshit-gangal
feat: add support for values statement with list argument bind variab…
258d329 
…le. Added new Row_Tuple bind variable type for formatting in vttablet

Signed-off-by: Harshit Gangal <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
@systay @harshit-gangal
minor tweaks
e9b7d2d 
Signed-off-by: Andres Taylor <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
@GuptaManan100 @harshit-gangal
feat: fix parsing for values
c46af56 
Signed-off-by: Manan Gupta <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
@harshit-gangal harshit-gangal added Type: Enhancement Logical improvement (somewhere between a bug and feature) Component: Query Serving labels Jan 9, 2025
@vitess-bot vitess-bot
Copy link
Contributor

vitess-bot bot commented Jan 9, 2025

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Jan 9, 2025
@github-actions github-actions bot added this to the v22.0.0 milestone Jan 9, 2025
@frouioui frouioui removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Jan 9, 2025
@harshit-gangal harshit-gangal mentioned this pull request Jan 9, 2025
Draft
@systay systay changed the title Values join ast and engine Values join AST and parsing Jan 9, 2025
@systay systay changed the title Values join AST and parsing VALUES statement AST and parsing Jan 9, 2025
GrahamCampbell
GrahamCampbell reviewed Jan 9, 2025
View reviewed changes
proto/query.proto Outdated Show resolved Hide resolved
@frouioui
Fix missing space
f435778 
Signed-off-by: Florent Poinsard <[email protected]>
@codecov Codecov
Copy link

codecov bot commented Jan 9, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 14.15929% with 97 lines in your changes missing coverage. Please review.

Project coverage is 67.67%. Comparing base (aabf1c9) to head (c1cbae5).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
go/vt/sqlparser/ast.go 0.00% 57 Missing ⚠️
go/vt/sqlparser/ast_funcs.go 19.35% 25 Missing ⚠️
go/vt/sqlparser/ast_format.go 0.00% 15 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #17500      +/-   ##
==========================================
- Coverage   67.68%   67.67%   -0.02%     
==========================================
  Files        1584     1584              
  Lines      254466   254523      +57     
==========================================
+ Hits       172235   172236       +1     
- Misses      82231    82287      +56

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@harshit-gangal
java: fix test
c1cbae5 
Signed-off-by: Harshit Gangal <[email protected]>
systay
systay reviewed Jan 10, 2025
View reviewed changes
go/vt/sqlparser/ast_funcs.go

func (node *ValuesStatement) SetLock(lock Lock) {
if lock != NoLock {
panic("cannot set lock on Values statement")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm... This doesn't look right.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is used in grammar, as part of the interface.
We can choose to ignore it if not panic

systay
systay requested changes Jan 10, 2025
View reviewed changes
Copy link
Collaborator

@systay systay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't panic in ast_funcs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frouioui frouioui frouioui approved these changes

@GrahamCampbell GrahamCampbell GrahamCampbell left review comments

@systay systay systay requested changes

@deepthi deepthi Awaiting requested review from deepthi deepthi is a code owner

@mattlord mattlord Awaiting requested review from mattlord mattlord is a code owner

@GuptaManan100 GuptaManan100 Awaiting requested review from GuptaManan100 GuptaManan100 is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
Component: Query Serving Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Milestone
v22.0.0
Development

Successfully merging this pull request may close these issues.
5 participants
@harshit-gangal @systay @GrahamCampbell @frouioui @GuptaManan100