Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VReplication: Improve error handling in VTGate VStreams #17558

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

mattlord
Copy link
Contributor

@mattlord mattlord commented Jan 16, 2025

Description

This PR improves the error handling for VTGate VStreams by adding additional context to the error whenever we can. The issue (#17548) mentioned lower level MySQL errors that were previously addressed in #12095 but this PR goes over the full path and makes some minor but nice improvements.

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

@mattlord mattlord added Type: Enhancement Logical improvement (somewhere between a bug and feature) Component: VReplication labels Jan 16, 2025
Copy link
Contributor

vitess-bot bot commented Jan 16, 2025

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Jan 16, 2025
@github-actions github-actions bot added this to the v22.0.0 milestone Jan 16, 2025
@mattlord mattlord removed NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Jan 16, 2025
@mattlord mattlord force-pushed the vstream_err_handling branch from 50513d2 to e5d2b25 Compare January 16, 2025 17:06
@mattlord mattlord force-pushed the vstream_err_handling branch from e5d2b25 to 1f7870f Compare January 16, 2025 17:36
Copy link

codecov bot commented Jan 16, 2025

Codecov Report

Attention: Patch coverage is 32.55814% with 58 lines in your changes missing coverage. Please review.

Project coverage is 67.80%. Comparing base (71b2cae) to head (bc558bf).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
go/vt/vtgate/vstream_manager.go 43.33% 34 Missing ⚠️
go/vt/vttablet/tabletserver/vstreamer/vstreamer.go 7.69% 24 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17558      +/-   ##
==========================================
+ Coverage   67.77%   67.80%   +0.02%     
==========================================
  Files        1587     1587              
  Lines      255798   255854      +56     
==========================================
+ Hits       173379   173474      +95     
+ Misses      82419    82380      -39     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Matt Lord <[email protected]>
Signed-off-by: Matt Lord <[email protected]>
Don't retry if topo server can't resolve in the vtgate

Signed-off-by: Matt Lord <[email protected]>
@mattlord mattlord force-pushed the vstream_err_handling branch from 338bb02 to be74e0c Compare January 31, 2025 16:38
@mattlord mattlord removed the NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work label Feb 5, 2025
@mattlord mattlord marked this pull request as ready for review February 5, 2025 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: VReplication Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Improve VStream Error Messages
2 participants