-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VReplication: Improve error handling in VTGate VStreams #17558
Open
mattlord
wants to merge
8
commits into
vitessio:main
Choose a base branch
from
planetscale:vstream_err_handling
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+97
−69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattlord
added
Type: Enhancement
Logical improvement (somewhere between a bug and feature)
Component: VReplication
labels
Jan 16, 2025
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
vitess-bot
bot
added
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsIssue
A linked issue is missing for this Pull Request
NeedsWebsiteDocsUpdate
What it says
labels
Jan 16, 2025
mattlord
removed
NeedsWebsiteDocsUpdate
What it says
NeedsIssue
A linked issue is missing for this Pull Request
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
labels
Jan 16, 2025
mattlord
force-pushed
the
vstream_err_handling
branch
from
January 16, 2025 17:06
50513d2
to
e5d2b25
Compare
twthorn
reviewed
Jan 16, 2025
Signed-off-by: Matt Lord <[email protected]>
mattlord
force-pushed
the
vstream_err_handling
branch
from
January 16, 2025 17:36
e5d2b25
to
1f7870f
Compare
Signed-off-by: Matt Lord <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17558 +/- ##
==========================================
+ Coverage 67.77% 67.80% +0.02%
==========================================
Files 1587 1587
Lines 255798 255854 +56
==========================================
+ Hits 173379 173474 +95
+ Misses 82419 82380 -39 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Matt Lord <[email protected]>
Signed-off-by: Matt Lord <[email protected]>
Don't retry if topo server can't resolve in the vtgate Signed-off-by: Matt Lord <[email protected]>
mattlord
force-pushed
the
vstream_err_handling
branch
from
January 31, 2025 16:38
338bb02
to
be74e0c
Compare
This reverts commit a136b86. Signed-off-by: Matt Lord <[email protected]>
Signed-off-by: Matt Lord <[email protected]>
Signed-off-by: Matt Lord <[email protected]>
mattlord
removed
the
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
label
Feb 5, 2025
mattlord
requested review from
harshit-gangal,
systay,
shlomi-noach and
rohit-nayak-ps
as code owners
February 5, 2025 20:50
mattlord
removed request for
deepthi,
systay,
timvaillancourt and
harshit-gangal
February 5, 2025 20:51
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR improves the error handling for VTGate VStreams by adding additional context to the error whenever we can. The issue (#17548) mentioned lower level MySQL errors that were previously addressed in #12095 but this PR goes over the full path and makes some minor but nice improvements.
Related Issue(s)
Checklist