-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve tablet types to wait #17622
base: main
Are you sure you want to change the base?
Improve tablet types to wait #17622
Conversation
Signed-off-by: Eduardo J. Ortega U. <[email protected]>
Signed-off-by: Eduardo J. Ortega U. <[email protected]>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17622 +/- ##
==========================================
- Coverage 67.75% 67.73% -0.02%
==========================================
Files 1586 1587 +1
Lines 255726 255798 +72
==========================================
+ Hits 173261 173274 +13
- Misses 82465 82524 +59 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Eduardo J. Ortega U. <[email protected]>
The test needed an extra tablet because the vtgate start-up script is waiting for primary and replica, but we were only provisioning primary. Signed-off-by: Eduardo J. Ortega U. <[email protected]>
@@ -30,8 +30,10 @@ fi | |||
CELL=zone1 ../common/scripts/vtctld-up.sh | |||
|
|||
# start unsharded keyspace and tablet | |||
CELL=zone1 TABLET_UID=100 ../common/scripts/mysqlctl-up.sh | |||
SHARD=0 CELL=zone1 KEYSPACE=main TABLET_UID=100 ../common/scripts/vttablet-up.sh | |||
for T_UID in 100 101; do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need two tablets here because the vtgate
start-up script waits for primary,replica
and with a single tablet we end up with no replicas.
Signed-off-by: Eduardo J. Ortega U. <[email protected]>
Description
This PR improves handling of
vtgate --tablet_types_to_wait
so that timeouts waiting for tablets are interpretedas not having successfully gotten healthchecks for all tablet types in all keyspaces of interest, leading to
retries instead of simply logging the error and continuing.
Related Issue(s)
#17412
Checklist
Deployment Notes
N/A