-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Online DDL: removal of gh-ost
and pt-osc
strategies
#17626
Draft
shlomi-noach
wants to merge
3
commits into
vitessio:main
Choose a base branch
from
planetscale:remove-gh-ost-pt-osc
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+25
−898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
vitess-bot
bot
added
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsIssue
A linked issue is missing for this Pull Request
NeedsWebsiteDocsUpdate
What it says
labels
Jan 26, 2025
shlomi-noach
added
Type: Internal Cleanup
release notes (needs details)
This PR needs to be listed in the release notes in a dedicated section (deprecation notice, etc...)
Component: Online DDL
Online DDL (vitess/native/gh-ost/pt-osc)
and removed
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsIssue
A linked issue is missing for this Pull Request
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
labels
Jan 26, 2025
Signed-off-by: Shlomi Noach <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17626 +/- ##
==========================================
+ Coverage 67.68% 67.80% +0.12%
==========================================
Files 1586 1585 -1
Lines 255413 254971 -442
==========================================
+ Hits 172883 172893 +10
+ Misses 82530 82078 -452 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Component: Online DDL
Online DDL (vitess/native/gh-ost/pt-osc)
NeedsWebsiteDocsUpdate
What it says
release notes (needs details)
This PR needs to be listed in the release notes in a dedicated section (deprecation notice, etc...)
Type: Internal Cleanup
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR completely removes any
gh-ost
andpt-online-schema-change
support, functionality, and flags from Vitess Online DDL.This means all of the following yields errors:
The remaining strategies are:
vitess
(akaonline
, both are allowed)mysql
(not Online, but still managed)direct
(unmanaged)Requires documentation updates! website/docs issue TBD.
Related Issue(s)
gh-ost
andpt-osc
Online DDL strategies #15692gh-ost
DDL strategy #15693gh-ost
website#1725Checklist
Deployment Notes