-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix integer parsing logic #17650
Merged
Merged
Fix integer parsing logic #17650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have various places where the types of what we parse and then use don't align. This is something CodeQL correctly warns about that it can lead to unexpected behavior with truncation. This fixes those cases that CodeQL is complaining about. Signed-off-by: Dirkjan Bussink <[email protected]>
dbussink
added
Type: Internal Cleanup
Component: General
Changes throughout the code base
labels
Jan 29, 2025
dbussink
requested review from
ajm188,
GuptaManan100,
rohit-nayak-ps,
shlomi-noach,
harshit-gangal,
systay,
timvaillancourt,
deepthi,
notfelineit and
mattlord
as code owners
January 29, 2025 15:52
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
vitess-bot
bot
added
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsIssue
A linked issue is missing for this Pull Request
NeedsWebsiteDocsUpdate
What it says
labels
Jan 29, 2025
dbussink
removed
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsWebsiteDocsUpdate
What it says
NeedsIssue
A linked issue is missing for this Pull Request
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
labels
Jan 29, 2025
Signed-off-by: Dirkjan Bussink <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17650 +/- ##
==========================================
- Coverage 67.76% 67.74% -0.03%
==========================================
Files 1586 1586
Lines 255763 255767 +4
==========================================
- Hits 173315 173264 -51
- Misses 82448 82503 +55 ☔ View full report in Codecov by Sentry. |
frouioui
approved these changes
Jan 30, 2025
deepthi
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have various places where the types of what we parse and then use don't align. This is something CodeQL correctly warns about that it can lead to unexpected behavior with truncation.
This fixes those cases that CodeQL is complaining about.
Related Issue(s)
https://github.com/vitessio/vitess/security/code-scanning/793
https://github.com/vitessio/vitess/security/code-scanning/792
https://github.com/vitessio/vitess/security/code-scanning/1931
https://github.com/vitessio/vitess/security/code-scanning/1927
https://github.com/vitessio/vitess/security/code-scanning/1926
https://github.com/vitessio/vitess/security/code-scanning/1925
https://github.com/vitessio/vitess/security/code-scanning/1924
https://github.com/vitessio/vitess/security/code-scanning/1923
https://github.com/vitessio/vitess/security/code-scanning/1922
https://github.com/vitessio/vitess/security/code-scanning/1921
Checklist