Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update wording to Vitest 3.0 #7351

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

runyasak
Copy link

Description

I noticed that some parts of the migration guide referred to Vitest 4.0, which I believe should be Vitest 3.0. Then, I’ve updated it.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

If you have any feedback or suggestions, please let me know.

Copy link

netlify bot commented Jan 23, 2025

Deploy Preview for vitest-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit b44a9e4
🔍 Latest deploy log https://app.netlify.com/sites/vitest-dev/deploys/679275a716e95a000807c9ac
😎 Deploy Preview https://deploy-preview-7351--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@@ -21,7 +21,7 @@ test('validation works', { retry: 3 }, () => { // [!code ++]
})
```

Vitest 4.0 will throw an error if the third argument is an object. Note that the timeout number is not deprecated:
Vitest 3.0 will throw an error if the third argument is an object. Note that the timeout number is not deprecated:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vitest 3 is out and it doesn't throw an error, it prints a warning (see paragraph above)

Vitest 4 (the next major) however will throw an error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants