Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: require fake timers for mocking date #7404

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

hi-ogawa
Copy link
Contributor

@hi-ogawa hi-ogawa commented Feb 2, 2025

Description

WIP

While checking #7329, I was slightly confused about this feature allowing mocking date vi.setSystemTime without vi.useFakeTimers. I'd assume historically Vitest had "mockdate" feature (vi.mockCurrentDate), which is later replaced with Jest-like API vi.setSystemTime #531, but then that required vi.useFakeTimers, so vi.setSystemTime only mocking is added back in #639.

Having two system internally (and two flags _fakingTime and _fakingDate) looks confusing and maybe removing this is fine later time on breaking change. Users can probably migrate to vi.useFakeTimers({ toFake: ["Date"] }).

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

Copy link

netlify bot commented Feb 2, 2025

Deploy Preview for vitest-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit fcdecf2
🔍 Latest deploy log https://app.netlify.com/sites/vitest-dev/deploys/679f1dd3358bae0008543498
😎 Deploy Preview https://deploy-preview-7404--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@hi-ogawa hi-ogawa changed the title refactor!: remove mocking Date only without fake timers refactor!: require fake timers for mocking date Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant