Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix easings import in plot examples #176

Merged
merged 1 commit into from
Oct 20, 2023

Conversation

ttytm
Copy link
Member

@ttytm ttytm commented Oct 20, 2023

Currently, I'm running into an error when trying to run the plot examples related to the changes in this PR. This update of the import allows me to run the plot examples.

@coderabbitai
Copy link

coderabbitai bot commented Oct 20, 2023

Walkthrough

The changes across the three files are primarily focused on the import statements. The easings module, previously imported from an unspecified location, is now being imported from the vsl package.

Changes

File Path Summary
examples/plot_scatter3d_easing/main.v The easings module is now imported from the vsl package.
examples/plot_scatter_easing/main.v The easings module is now imported from the vsl package. This change may affect the usage of the easings module in the codebase.
examples/plot_surface_easing/main.v The easings module is now imported from the vsl package.

🐇

In the land of code, where the modules play,

The easings found a new home today.

From vsl they come, with a hop and a skip,

Making our codebase a much smoother trip. 🎉


Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • If you reply to a review comment from CodeRabbit, the bot will automatically respond.
  • To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
  • Note: Review comments are made on code diffs or files, not on the PR overview.

CodeRabbit Commands

  • Enter @coderabbitai pause as a PR comment to pause the reviews on a PR.
  • Enter @coderabbitai resume as a PR comment to resume the paused reviews.
  • For on-demand reviews, enter @coderabbitai review as a PR comment to trigger a review. This is useful when reviews are automatic disabled at the repository level.
  • Enter @coderabbitai: ignore in the PR description to stop a specific PR from being reviewed.

Note these commands work only in the PR comment. For conversations with the bot, please use the review comments on code diffs or files.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Commits Files that changed from the base of the PR and between 6904d72 and c0675f1.
Files selected for processing (3)
  • examples/plot_scatter3d_easing/main.v (1 hunks)
  • examples/plot_scatter_easing/main.v (1 hunks)
  • examples/plot_surface_easing/main.v (1 hunks)
Files skipped from review due to trivial changes (2)
  • examples/plot_scatter3d_easing/main.v
  • examples/plot_surface_easing/main.v
Additional comments (Suppressed): 1
examples/plot_scatter_easing/main.v (1)
  • 1-3: The import statement for the easings module has been updated to reflect its new location in the vsl package. Ensure that the vsl package is correctly installed and the easings module is available at the specified location.

Copy link
Member

@ulises-jeremias ulises-jeremias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@ulises-jeremias ulises-jeremias merged commit ab54fe1 into vlang:main Oct 20, 2023
10 checks passed
@ttytm ttytm deleted the fix/examples-easings-import branch October 24, 2023 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants