-
-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix opencl usage and example compilation on macOS #185
Conversation
WalkthroughThis pull request introduces changes to the CI/CD pipeline, compilation process, and platform-specific code adjustments for Apple systems. The modifications aim to enhance the project's compatibility with OpenCL libraries and Apple platforms, and to include examples in the test suite. Changes
TipsChat with CodeRabbit Bot (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (3)
- .github/workflows/ci.yml (1 hunks)
- bin/test (1 hunks)
- vcl/vcl.h (1 hunks)
Files skipped from review due to trivial changes (2)
- .github/workflows/ci.yml
- vcl/vcl.h
Additional comments: 1
bin/test (1)
- 68-68: The
-d dlopencl
flag has been added to the compilation command. This flag is related to the dynamic loading of OpenCL libraries, which is necessary for macOS compatibility. Ensure that this flag does not affect the compilation process on other platforms.- v ${flags} -o "${file}.o" "${file}" + v ${flags} -d dlopencl -o "${file}.o" "${file}"Committable suggestion (Beta)
echo "Compiling ${file}" v ${flags} -d dlopencl -o "${file}.o" "${file}" echo "${file}.o created" echo "Removing ${file}.o" rm -f "${file}.o"
This PR should fix opencl usage on macOS.
Now it should be possible to run the opencl examples that used to fail macos. They run locally tested on my mac machine.
But I think the example compilation via the script is false positive. E.g., on my linux main machine I can compile the opencl examples but it's not possible to run them.
I'd address a CI improvement in a separate PR.
Summary by CodeRabbit
Please note, these changes may not directly impact the user interface but contribute to the overall performance and reliability of our software.