This repository has been archived by the owner on Mar 6, 2024. It is now read-only.
Add j2cl demo #11
Merged
Add j2cl demo #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdeleuze
suggested changes
Jun 7, 2022
There was a problem hiding this comment.
Thanks for contributing this sample, could you please:
- Add a proper
README.mdlike other samples (especially needed for this one). - Add a
run.shscript that will run thebazel run src/main/java/com/google/j2cl/samples/wasm:jsapp_dev_serverlike other samples. - Expose the running dev server on port 8000 in order to make it accessible on the host where
google-chrome-unstableis expected to run (I am curious how did you test it without that). - Move the sample to
java/browser-hello-world. Check if that's possible to perform DOM manipulation on Java side to be consistent with other samples.
|
It's currently not possible to run the server on a different port (google/j2cl#147), but I tidied up the other stuff. Up to you to decide what to do about the port. There is a change in the pipeline (bazelbuild/rules_closure#557) that makes the ipv6 requirement go away, so I guess we could wait for that. |
|
The upstream changes have been merged, so this should now work with ipv4 and on port 8000. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In /etc/docker/daemon.json:
"ipv6": true, "fixed-cidr-v6": "fd00::/80"
and
$ sudo systemctl restart docker