Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for OCI tarball url #8184

Merged
merged 12 commits into from
Dec 24, 2024

Conversation

migruiz4
Copy link
Contributor

@migruiz4 migruiz4 commented Dec 20, 2024

Description of the change

This PR aims to fix #8153 by resolving this error:

E1219 15:25:15.632218       1 utils.go:1024] Failed to import files, ID=bitnami/nginx, version=17.3.3: Get "oci://registry-1.docker.io/bitnamicharts/nginx:17.3.3": unsupported protocol scheme "oci"

Benefits

Currently, the kubeapps-asset-syncer is unable to fetch the information when the chart URL is stored in OCI.

In this PR, the chart tarballUrl is transformed when the oci schema is detected and replaced by its OCI blob URL, so the asset syncer will be able to fetch the chart tarball the same way as it does for non-OCI charts.

Possible drawbacks

None known.

Applicable issues

cmd/asset-syncer/server/utils.go Outdated Show resolved Hide resolved
cmd/asset-syncer/server/utils.go Outdated Show resolved Hide resolved
Signed-off-by: Miguel Ruiz <[email protected]>
Signed-off-by: Miguel Ruiz <[email protected]>
Signed-off-by: Miguel Ruiz <[email protected]>
@beltran-rubo beltran-rubo enabled auto-merge (squash) December 24, 2024 08:06
@beltran-rubo beltran-rubo merged commit c0fabfb into vmware-tanzu:main Dec 24, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants