Skip to content

Commit

Permalink
Merge pull request #4083 from sgairo/sophie-vicadm
Browse files Browse the repository at this point in the history
Correct typos in documentation and error messaging
  • Loading branch information
sgairo authored Mar 2, 2017
2 parents d08e396 + b43505d commit f5d2542
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion doc/design/arch/vic-port-layer-overview.md
Original file line number Diff line number Diff line change
Expand Up @@ -40,4 +40,4 @@ It stands to reason that Networking, Storage and Execution are obvious areas for

For example, what is a container storage Volume and how should one be configured? The Port Layer API should be responsible for deciding what vSphere construct most appropriately represents a Volume and also that it is configured appropriately. It should do this based on the parameters passed in, the vSphere features currently installed in the system and the resources that the tenant has the authorization to access. It can pass back a handle to that Volume that can then be used in the creation of a container. By doing this, the Port Layer made a choice about the most appropriate underlying representation and it also made sure it was appropriately configured and indexed.

To some extent there is an inevitable overlap with the goals of other projects in this sphere, such as https://github.com/opencontainers/runc. While this is hardly surprising given that the Port Layer is attempting to make opinionated choices in exactly the same problem domain, it would be wrong to infer that this makes it an intentional fragementation or competing API. It is our explicit intention that the two should be entirely complimentary and that the Port Layer should be the lowest level of abstraction that a VIC implementation of runc would end up calling. If the abstractions are correct, it should be just as possible to build an implementation of https://github.com/coreos/rkt/blob/master/Documentation/app-container.md using the same APIs.
To some extent there is an inevitable overlap with the goals of other projects in this sphere, such as https://github.com/opencontainers/runc. While this is hardly surprising given that the Port Layer is attempting to make opinionated choices in exactly the same problem domain, it would be wrong to infer that this makes it an intentional fragmentation or competing API. It is our explicit intention that the two should be entirely complimentary and that the Port Layer should be the lowest level of abstraction that a VIC implementation of runc would end up calling. If the abstractions are correct, it should be just as possible to build an implementation of https://github.com/coreos/rkt/blob/master/Documentation/app-container.md using the same APIs.
2 changes: 1 addition & 1 deletion lib/install/validate/validator.go
Original file line number Diff line number Diff line change
Expand Up @@ -401,7 +401,7 @@ func (v *Validator) credentials(ctx context.Context, input *data.Data, conf *con

vimClient, err := vim25.NewClient(ctx, soapClient)
if err != nil {
v.NoteIssue(fmt.Errorf("Failed to create client for validaiton of operations credentials: %s", err))
v.NoteIssue(fmt.Errorf("Failed to create client for validation of operations credentials: %s", err))
return
}

Expand Down

0 comments on commit f5d2542

Please sign in to comment.