Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve organization page info #67

Merged
merged 12 commits into from
Jul 24, 2024
Merged

Improve organization page info #67

merged 12 commits into from
Jul 24, 2024

Conversation

selankon
Copy link
Collaborator

@selankon selankon commented Jul 19, 2024

Fixes some of #65

Atm there is no way to get the total fees of an account so the paginator is just a next/back one

It also splits the components into different files

Copy link

github-actions bot commented Jul 19, 2024

@github-actions github-actions bot temporarily deployed to pull request July 19, 2024 08:35 Inactive
Copy link

github-actions bot commented Jul 19, 2024

@github-actions github-actions bot temporarily deployed to pull request July 19, 2024 08:35 Inactive
@selankon selankon force-pushed the f/add-account-info branch from df2ee11 to 0832119 Compare July 23, 2024 10:02
@github-actions github-actions bot temporarily deployed to pull request July 23, 2024 10:55 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 23, 2024 10:55 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 23, 2024 14:09 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 23, 2024 14:09 Inactive
@selankon selankon requested a review from elboletaire July 23, 2024 14:15
@selankon selankon marked this pull request as ready for review July 23, 2024 14:15
src/components/Organizations/Details/Elections.tsx Outdated Show resolved Hide resolved
src/components/Organizations/Details/Fees.tsx Outdated Show resolved Hide resolved
src/components/Organizations/Detail.tsx Outdated Show resolved Hide resolved
@elboletaire
Copy link
Member

After marking the review as ready I realized the pagination in fees does not work very well, but I guess that's related to the other pagination problems, right?

@github-actions github-actions bot temporarily deployed to pull request July 24, 2024 07:07 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 24, 2024 07:07 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 24, 2024 07:07 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 24, 2024 07:30 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 24, 2024 07:30 Inactive
@elboletaire elboletaire merged commit 9652ed6 into main Jul 24, 2024
3 checks passed
@elboletaire elboletaire deleted the f/add-account-info branch July 24, 2024 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants