Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Settings sidebar with theme toggle #46

Merged
merged 6 commits into from
Feb 5, 2025
Merged

feat: Settings sidebar with theme toggle #46

merged 6 commits into from
Feb 5, 2025
+475 −44

Conversation

g3n35i5
Copy link
Member

@g3n35i5 g3n35i5 commented Feb 5, 2025

Adds a settings sidebar with theme toggle options.
The selected theme is applied to the embedded documentation as well.

2025-02-05_12.29.44.848.mp4

@g3n35i5
test: Use sphinxawesome-theme as example docs theme and misc
e1ec52e 
- Fix permalink icon
- Add version to docu header
- Remove sphinx footer
@g3n35i5
refactor(tests): Move page.goto('/') from baseTest to each test
1d59acf
@g3n35i5
feat(ui): Add settings sidebar and enable color theme toggle
ab98c7e 
The selected theme is propagated to the embedded documentation
as well.
@g3n35i5 g3n35i5 added the rebase Merge this PR with rebase strategy label Feb 5, 2025
@g3n35i5 g3n35i5 marked this pull request as ready for review February 5, 2025 11:35
@MichaelBarulin
Copy link
Contributor

Soll nun light das default sein wenn nichts explizit gesetzt ist?
Außerdem fehlen tests, die den übergang von ausgewähltem light/dark (nicht system) zum jeweils anderen testen (und zu system zurück).

@g3n35i5
Copy link
Member Author

g3n35i5 commented Feb 5, 2025

Ich habe keinen weg gefunden, das default theme auf dark zu setzen.
Ich vermute, dass das damit zu tun hat, dass lt. CSS @media prefers-color-scheme die spezifikation bei undefined ist, dass light default ist.

christiangrett
christiangrett reviewed Feb 5, 2025
View reviewed changes
src/ui/MenuBar.tsx Outdated Show resolved Hide resolved
christiangrett
christiangrett reviewed Feb 5, 2025
View reviewed changes
src/ui/MenuBar.tsx Outdated Show resolved Hide resolved
src/ui/MenuBar.tsx Outdated Show resolved Hide resolved
src/ui/routes/$projectName/$version.$.tsx Show resolved Hide resolved
src/ui/routes/$projectName/$version.$.tsx Outdated Show resolved Hide resolved
@g3n35i5 g3n35i5 merged commit 3824a27 into main Feb 5, 2025
17 checks passed
@g3n35i5 g3n35i5 deleted the feat/dark-mode branch February 5, 2025 16:53
christiangrett
christiangrett reviewed Feb 6, 2025
View reviewed changes
Copy link

@christiangrett christiangrett left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Das mit dem Key und dem IFrame stimmt. Ich hatte den Rest des Codes noch nicht betrachet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christiangrett christiangrett christiangrett left review comments

@MichaelBarulin MichaelBarulin MichaelBarulin approved these changes

Assignees
No one assigned
Labels
rebase Merge this PR with rebase strategy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@g3n35i5 @MichaelBarulin @christiangrett