Center pop-up in window #41 #79
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| var mutch_w = regex.exec(options.width); | ||
| var mutch_h= regex.exec(options.height); | ||
|
|
||
| maxWidth = mutch_w? mutch_w[1] * window_width / 100 : options.height; |
There was a problem hiding this comment.
Minor fix here: I think this should be options.width
Thanks for these fixes! Without them, this library wouldn't work for us at all. As it is, we'll give it a shot.
|
Any idea how long this pull will take to be merged ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I managed to fix #41
additionally, it is inconvenient that couldn't use with Parallax Scrolling page, because $(window).scrollTop always returns 0.
because this issue caused by the option
html, body{ height: 100%}I try not to use it.and i added an option to show pop-up in the center.