Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<feat> implemented Liner Quadratic Regulator #500

Open
wants to merge 17 commits into
base: develop
Choose a base branch
from

Conversation

Q3rkses
Copy link

@Q3rkses Q3rkses commented Nov 10, 2024

Fixed everything, AUV works flawlessly now.

@Q3rkses Q3rkses added the Auto label Nov 10, 2024
@Q3rkses Q3rkses self-assigned this Nov 10, 2024
@Andeshog Andeshog requested a review from chrstrom November 10, 2024 17:43
@chrstrom chrstrom removed their request for review November 10, 2024 17:53
Copy link

@Talhanc Talhanc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything else was nice : )

@kluge7 kluge7 force-pushed the 435-task-velocity-controller-pog branch from 8ee813a to 9a171f1 Compare November 10, 2024 18:07
@Andeshog Andeshog removed their assignment Nov 10, 2024
@kluge7 kluge7 linked an issue Nov 10, 2024 that may be closed by this pull request
3 tasks
@Q3rkses Q3rkses requested review from Andeshog and kluge7 November 15, 2024 14:40
control/velocity_controller_lqr/package.xml Outdated Show resolved Hide resolved
requirements.sh Outdated Show resolved Hide resolved
@kluge7 kluge7 self-requested a review November 17, 2024 14:45
@Q3rkses Q3rkses requested a review from Andeshog January 6, 2025 11:51
Comment on lines 2 to 28
ros__parameters:

#topic parameters
odom_topic: /nucleus/odom
guidance_topic: /guidance/los
thrust_topic: /thrust/wrench_input

#LQR parameters

q_surge: 75
q_pitch: 175
q_yaw: 175

r_surge: 0.3
r_pitch: 0.4
r_yaw: 0.4

i_surge: 0.3
i_pitch: 0.4
i_yaw: 0.3

i_weight: 0.5

inertia_matrix: [30.0, 0.6, 0.0, 0.6, 1.629, 0.0, 0.0, 0.0, 1.729]

#Clamp parameter
max_force: 99.5
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here you could do something like

ros__parameters:
    topics:
        odom_topic: ...
        ...
    LQR_params:
        q_surge: ...
        ...

Comment on lines 302 to 304

# ---------------------------------------------------------------Main Function---------------------------------------------------------------

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

old?

@Q3rkses Q3rkses requested review from Andeshog and Talhanc January 7, 2025 15:28
Copy link
Contributor

@Andeshog Andeshog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there now

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file can be deleted

Comment on lines 256 to 261
if self.controller.killswitch == False:
if self.controller.operation_mode == "autonomous mode":
self.publisherLQR.publish(msg)

else:
self.controller.reset_controller()
else:
self.controller.reset_controller()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not necessary to nest here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TASK] Velocity Controller
4 participants