Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve language identifying Legislature for states, cities & counties #165

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dallasjc
Copy link
Contributor

On the endorsement page, we put Legislature for all jurisdictions except Congress.

This pr adds the appropriate name for states (State Legislature, General Assembly, General Court), changes Legislature to Supervisor for counties, and makes Council the default for cities. I checked the top 50 cities and they all use some variation of Council (Common Council, City Council, General Council, etc), except Miami and SF, which I added special language for

I created an unusual check for states where the legislature should be called General Assembly, but I confirmed it's working by testing it with Wisconsin and California

image

image

image

@alexmingoia
Copy link
Member

alexmingoia commented Jul 30, 2019

This should not be done here. The data should be changed in the database. States, legislatures, offices, all have a long and short names already in the database.

@alexmingoia
Copy link
Member

alexmingoia commented Jul 31, 2019

Shortening "board of supervisors" to "supervisors" and "city council", "common council" etc. to "council" sounds weird. If we're going to display the name of the legislature let's be consistent and use the complete name.

Send me a CSV with format old_name, new_name, new_short_name to update legislature names and I can update them. You can query all the legislature data at api.liquid.us/legislatures and even get it in CSV format with Accept: text/csv header.

@dallasjc
Copy link
Contributor Author

dallasjc commented Aug 12, 2019 via email

@alexmingoia
Copy link
Member

alexmingoia commented Aug 12, 2019

How about creating a legislature_title column instead of replacing the name?

Can you help me understand the need for a third name field? Legislatures already have two fields for a name, the full one and a short one.

Changing the name would mean other changes in the code - short_name instead of
legislature_name in a bunch of places. Also unclear what should be short_name
for states - Alabama or AL?

Names of legislatures aren't IDs. There shouldn't be any code on the front-end that depends on using legislature names as IDs or keys. If there is it should be removed. That's because we want the ability to edit the names without changing any code.

I've attached two versions of the csv

I think you forgot to include the attachments, or they were lost because you're replying to GitHub issues via email.

@dallasjc
Copy link
Contributor Author

dallasjc commented Aug 13, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants