-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve language identifying Legislature for states, cities & counties #165
base: master
Are you sure you want to change the base?
Conversation
This should not be done here. The data should be changed in the database. States, legislatures, offices, all have a long and short names already in the database. |
Shortening "board of supervisors" to "supervisors" and "city council", "common council" etc. to "council" sounds weird. If we're going to display the name of the legislature let's be consistent and use the complete name. Send me a CSV with format |
How about creating a legislature_title column instead of replacing the name?
Changing the name would mean other changes in the code - short_name instead of
legislature_name in a bunch of places. Also unclear what should be short_name
for states - Alabama or AL?
One note - I included cities and one county that are not already in the
database, partly so we'd have the right info for cities with candidates we're
targeting. Is that a problem? Will the data be stored for future use? I can add
any additional data you need.
I've attached two versions of the csv - one with the columns you asked for and
one with legislature_name and legislature_title for use as I mentioned above.
On Wed, Jul 31, 2019 3:42 AM, Alex Mingoia [email protected] wrote:
Shortening "board of supervisors" to "supervisors" and "city council", "common
council" etc. to "council" sounds weird. If we're going to display the name of
the legislature let's be consistent and use the complete name.
Send me a CSV with format old_name, new_name, new_short_name to update
legislature names and I can update them.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Can you help me understand the need for a third name field? Legislatures already have two fields for a name, the full one and a short one.
Names of legislatures aren't IDs. There shouldn't be any code on the front-end that depends on using legislature names as IDs or keys. If there is it should be removed. That's because we want the ability to edit the names without changing any code.
I think you forgot to include the attachments, or they were lost because you're replying to GitHub issues via email. |
I'm not sure what you mean. Legislatures already have two columns for a name,
the full one and a short one.
Right, I'm suggesting we treat "Common Council", "State Legislature", etc as if
it's not part of the name by creating a new legislature_title column. We don't
need the new info most of the time legislature_name is called.
Legislature_name and short name would stay the same and we would add a column
just for the title - Common Council. So legislature_name = Madison, WI,
short_name = Madison, legislature_title = Common Council
Names of legislatures aren't IDs. There shouldn't be any code on the front-end
that depends on using legislature names as IDs or keys. If there is, it should
be removed.
You might be right, thought I saw some yesterday, but I don't see it now.
I'm sending another email to you with the csvs
On Mon, Aug 12, 2019 6:48 PM, Alex Mingoia [email protected] wrote:
How about creating a legislature_title column instead of replacing the name?
I'm not sure what you mean. Legislatures already have two columns for a name,
the full one and a short one.
Changing the name would mean other changes in the code - short_name instead of
legislature_name in a bunch of places. Also unclear what should be short_name
for states - Alabama or AL?
Names of legislatures aren't IDs. There shouldn't be any code on the front-end
that depends on using legislature names as IDs or keys. If there is, it should
be removed.
I've attached two versions of the csv
I think you forgot to include the attachments, or they were lost because you're
replying to GitHub issues via email.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
On the endorsement page, we put Legislature for all jurisdictions except Congress.
This pr adds the appropriate name for states (State Legislature, General Assembly, General Court), changes Legislature to Supervisor for counties, and makes Council the default for cities. I checked the top 50 cities and they all use some variation of Council (Common Council, City Council, General Council, etc), except Miami and SF, which I added special language for
I created an unusual check for states where the legislature should be called General Assembly, but I confirmed it's working by testing it with Wisconsin and California