.rspec: dont run with --fail-fast #1878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arjenz
approved these changes
May 11, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1878 +/- ##
=======================================
Coverage 74.29% 74.29%
=======================================
Files 79 79
Lines 4396 4396
=======================================
Hits 3266 3266
Misses 1130 1130 ☔ View full report in Codecov by Sentry. |
When this option is set, rspec will stop after the first failure. We don't have this enabled in any other project and I think it's useful to know if you've 20 errors or just one. And the CI runtime isn't that long, so IMO it's fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When this option is set, rspec will stop after the first failure. We don't have this enabled in any other project and I think it's useful to know if you've 20 errors or just one. And the CI runtime isn't that long, so IMO it's fine.