-
-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mongodb_exporter: Add acceptance tests #350
Conversation
Related to #366 |
Hello, What about this PR ? Applying the same modification as the postgresql exporter is working (c Do you want a PR with those modification (copypasting ?) Regards |
Hi @olivierHa, a PR if an acceptance test would be most welcome! |
Dear @bastelfreak, thanks for the PR! This is Vox Pupuli Tasks, your friendly Vox Pupuli Github Bot. I noticed that your pull request has CI failures. Can you please have a look at the failing CI jobs? |
Dear @bastelfreak, thanks for the PR! This is Vox Pupuli Tasks, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase? You can find my sourcecode at voxpupuli/vox-pupuli-tasks |
Dear @bastelfreak, thanks for the PR! This is Vox Pupuli Tasks, your friendly Vox Pupuli Github Bot. I noticed that your pull request has CI failures. Can you please have a look at the failing CI jobs? |
@bastelfreak mongodb_exporter needs to connect to a mongo instance when it starts up. I used simple mongo in docker when I tested it, is it possible to use in the acceptance test too? |
Pull Request (PR) description
This Pull Request (PR) fixes the following issues