Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mongodb_exporter: Add acceptance tests #350

Closed
wants to merge 1 commit into from
Closed

mongodb_exporter: Add acceptance tests #350

wants to merge 1 commit into from

Conversation

bastelfreak
Copy link
Member

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

@alexjfisher
Copy link
Member

Related to #366

@olivierHa
Copy link

Hello,

What about this PR ?
mongodb exporter version is now "0.11.0" and is still being extracted to /opt directly.

Applying the same modification as the postgresql exporter is working (c

Do you want a PR with those modification (copypasting ?)

Regards

@bastelfreak
Copy link
Member Author

Hi @olivierHa, a PR if an acceptance test would be most welcome!

@vox-pupuli-tasks
Copy link

Dear @bastelfreak, thanks for the PR!

This is Vox Pupuli Tasks, your friendly Vox Pupuli Github Bot. I noticed that your pull request has CI failures. Can you please have a look at the failing CI jobs?
If you need any help, you can reach out to us on our IRC channel voxpupuli on Freenode or our Slack channel voxpupuli at slack.puppet.com.
You can find my sourcecode at voxpupuli/vox-pupuli-tasks

@vox-pupuli-tasks
Copy link

Dear @bastelfreak, thanks for the PR!

This is Vox Pupuli Tasks, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks

@bastelfreak bastelfreak changed the title mongodb_exporter: Update 0.3.1->0.8.0 & Add acceptance tests mongodb_exporter: Add acceptance tests Aug 5, 2020
@vox-pupuli-tasks
Copy link

Dear @bastelfreak, thanks for the PR!

This is Vox Pupuli Tasks, your friendly Vox Pupuli Github Bot. I noticed that your pull request has CI failures. Can you please have a look at the failing CI jobs?
If you need any help, you can reach out to us on our IRC channel voxpupuli on Freenode or our Slack channel voxpupuli at slack.puppet.com.
You can find my sourcecode at voxpupuli/vox-pupuli-tasks

@kuldazbraslav
Copy link

@bastelfreak mongodb_exporter needs to connect to a mongo instance when it starts up. I used simple mongo in docker when I tested it, is it possible to use in the acceptance test too?

@bastelfreak bastelfreak closed this by deleting the head repository Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants