Support [Slice] in manage_unit and manage_dropin
#420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
traylenator
force-pushed
the
slice
branch
2 times, most recently
from
df9a311 to
cabd622
Compare
For example the following is now possible:
```puppet
systemd::manage_dropin { 'userlimits.conf':
unit => 'user-.slice',
slice_entry => {
MemoryMax => '10G',
MemoryAccounting => true,
}
}
```
The directives for `[Slice]` are typically a subset of `[Service]`.
* https://www.freedesktop.org/software/systemd/man/latest/systemd.slice.html
* https://www.freedesktop.org/software/systemd/man/latest/systemd.resource-control.html
TheMeier
reviewed
Mar 4, 2024
There was a problem hiding this comment.
There is also a couple more parameters in the latest systemd that are missing:
StartupCPUWeightAllowedCPUsStartupAllowedCPUsStartupMemoryLowDefaultStartupMemoryLowStartupMemoryLowDefaultStartupMemoryLowStartupMemoryHighStartupMemoryMaxStartupMemorySwapMaxMemoryZSwapMaxStartupMemoryZSwapMaxAllowedMemoryNodesStartupAllowedMemoryNodes
Disclaimer: I do not have experience with managing slices.
I wonder what the slice name user-.slice means. In the documentation I did only find the root slice -.slice 2nd level slices foo.slice and subsequent slices foo-bar.slice. So I assume user-.slice is equivalent to user.slice
…md::Unit::AmountOrPerecnt
I don't want to add everything. Get a good set in and things like |
TheMeier
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
For example the following is now possible:
The directives for
[Slice]are typically a subset of[Service].Adds new types:
This Pull Request (PR) fixes the following issues