Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libpinmame: Fix Dip Switch bug in wpc/core.c #185

Merged

Conversation

diego-link-eggy
Copy link
Contributor

From the code in wpc/core.c , it looks like the intent was for LIBPINMAME to use the VP Interface.

#if defined(VPINMAME) || defined(LIBPINMAME)  
#include "vpintf.h"

This PR adds the same define for core_getDip function further down in the same file

The code in win32com/Controller.cpp get_Dip and put_Dip functions also call to the VP Interface.

STDMETHODIMP CController::put_Dip(int nNo, int newVal)
{
	// TODO: Add your implementation code here. DONE
        vp_setDIP(nNo, newVal);
	return S_OK;
}

This change at least fixes the dipswitch reading on standalone branch of vpinball which would not read the
Controller.Dip()
when set .

@jsm174 jsm174 merged commit 6bb14f6 into vpinball:master Jan 5, 2024
8 checks passed
@jsm174
Copy link
Contributor

jsm174 commented Jan 5, 2024

Nice. Great catch! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants