Generally kill both parent and their child processes. (dotnet#1232)

vrockn · Dec 1, 2021 · a9a1b83 · a9a1b83
1 parent 311fb03
commit a9a1b83
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/Microsoft.Tye.Core/ProcessExtensions.cs b/src/Microsoft.Tye.Core/ProcessExtensions.cs
@@ -117,7 +117,7 @@ public static void RunProcessAndWaitForExit(string fileName, string arguments, T
             }
             else
             {
-                process?.Kill();
+                process?.Kill(entireProcessTree: true);
             }
         }
     }

diff --git a/src/Microsoft.Tye.Core/ProcessUtil.cs b/src/Microsoft.Tye.Core/ProcessUtil.cs
@@ -165,7 +165,7 @@ public static async Task<ProcessResult> RunAsync(
                 {
                     if (!process.CloseMainWindow())
                     {
-                        process.Kill();
+                        process.Kill(entireProcessTree: true);
                     }
                 }
 
@@ -177,7 +177,7 @@ public static async Task<ProcessResult> RunAsync(
 
                     if (!process.HasExited)
                     {
-                        process.Kill();
+                        process.Kill(entireProcessTree: true);
                     }
                 }
             }
@@ -197,7 +197,7 @@ public static void KillProcess(int pid)
             try
             {
                 using var process = Process.GetProcessById(pid);
-                process?.Kill();
+                process?.Kill(entireProcessTree: true);
             }
             catch (ArgumentException) { }
             catch (InvalidOperationException) { }
-Original file line number
+Diff line change
@@ Expand Up @@
                 }
                 else
                 {
-                    process?.Kill();
+                    process?.Kill(entireProcessTree: true);
                 }
             }
         }
@@ Expand Down @@