#381 Add Lilygo S3 board #383
Merged
+275
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The board implementation looks reasonable :) Is there anything special about the example? Shouldn't the normal demo just work? I'm not such a fan of adding more examples to maintain if they don't bring a big benefit. |
added 2 commits
December 30, 2024 12:17
|
Thanks, and sorry for the long wait! I just checked which IDF version the arduino core is using, but it looks like they have already moved to > 5.0, so I'd say it's safe to drop 4.x checks. |
vroland
approved these changes
Jan 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Untested with Hardware and still now ready for a review.
Please check #381 for more details