chore: configure pnpm and remove phantom deps #2665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matheusps
requested review from
renatamottam and
renatomaurovtex
and removed request for
a team
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
matheusps
force-pushed
the
chore/no-phanthom-deps
branch
from
2789b92 to
860d4b7
Compare
pedromtec
reviewed
Feb 5, 2025
| @@ -64,6 +69,12 @@ jobs: | |||
| - name: Clone starter | |||
| run: git clone https://github.com/vtex-sites/starter.store.git starter | |||
|
|
|||
| - name: Install specific Yarn version | |||
| run: npm install -g [email protected] # https://github.com/yarnpkg/yarn/issues/9015 | |||
There was a problem hiding this comment.
What would happen if the developer was using another version of yarn?
There was a problem hiding this comment.
This is a issue with yarn itself. It only happens on CI (running corepack on subfolders)
There was a problem hiding this comment.
I saw the issue now. It makes sense now.
pedromtec
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this pull request?