Adjust get_unspent_outs return error according to API standard #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
everoddandeven
force-pushed
the
fix/get_unspent_outs
branch
from
785b6d3 to
a5df510
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes a small enhancement on the
get_unspent_outsmethod, which returned the errorlws::error:account_not_foundwhen the amount received is not enough to satisfy the requested amount, in turn causing theHTTP 403 Forbiddenerror. A new errorlws::error:not_enough_amounthas been introduced that replaceslws::error::account_not_foundin this specific case, also thebad_requestmethod has been modified to correctly handle this new error and return theHTTP 400 Bad Requesterror according to the official light wallet API get_unspent_outs specification.