Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMakeLists: Remove manual pull-in of already found libraries #40

Open
wants to merge 2 commits into
base: release-v0.2_0.18
Choose a base branch
from

Conversation

j-berman
Copy link
Contributor

Bringing this commit by @TheCharlatan over from #30 also :)

@vtnerd
Copy link
Owner

vtnerd commented Jul 28, 2022

How much of a pain is it to get this mergeable with the develop branch? Arguably this one in particular (which fixes no bugs technically) should be made against that branch first before being pulled into other branches. One difficulty is that I have no CI system to verify this at the moment.

@j-berman
Copy link
Contributor Author

Not a pain :)

But adding, this PR is necessary for the release branch too otherwise the docker build errors out with a missing libzmq.so error at runtime.

I think if we squash commits before merging PR's it would be easier to track/cherry-pick all the right stuff going forward

@vtnerd
Copy link
Owner

vtnerd commented Jul 28, 2022

I think if we squash commits before merging PR's it would be easier to track/cherry-pick all the right stuff going forward

Agreed. I should've asked for a squashed commit before merging; I lost track of one commit and it caused some havoc.

@vtnerd vtnerd force-pushed the release-v0.2_0.18 branch from e8b1734 to 9715fdd Compare July 29, 2022 18:59
@vtnerd vtnerd force-pushed the release-v0.2_0.18 branch from aeee719 to 6df0a42 Compare October 28, 2022 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants