Merge pull request #12 from vtsykun/fix/php8.4

PHP 8.4 fix implicitly nullable parameter declarations deprecated
vtsykun · Mar 23, 2024 · d6a0c64 · d6a0c64
2 parents a9604af + 2d00b1d
commit d6a0c64
Show file tree

Hide file tree

Showing 10 changed files with 17 additions and 17 deletions.
diff --git a/src/Attribute/AsCron.php b/src/Attribute/AsCron.php
@@ -16,11 +16,11 @@ final class AsCron
 
     public function __construct(
         string $cron,
-        bool $lock = null,
-        bool $async = null,
+        ?bool $lock = null,
+        ?bool $async = null,
         array $options = [],
-        bool $messenger = null,
-        int $jitter = null,
+        ?bool $messenger = null,
+        ?int $jitter = null,
     ) {
         // Replace when update PHP > 7.2
         $this->async = $async;

diff --git a/src/Attribute/AsPeriodicTask.php b/src/Attribute/AsPeriodicTask.php
@@ -16,10 +16,10 @@ class AsPeriodicTask
 
     public function __construct(
         /*int|string */ $interval,
-        bool $lock = null,
-        bool $async = null,
-        bool $messenger = null,
-        int $jitter = null,
+        ?bool $lock = null,
+        ?bool $async = null,
+        ?bool $messenger = null,
+        ?int $jitter = null,
         array $options = [],
     ) {
         $this->async = $async;

diff --git a/src/Command/CronCommand.php b/src/Command/CronCommand.php
@@ -39,7 +39,7 @@ class CronCommand extends Command
      * @param PsrClockInterface|null $clock
      * @param string|null $timezone
      */
-    public function __construct(ScheduleRunnerInterface $scheduleRunner, ScheduleLoaderInterface $loader, EventDispatcherInterface $dispatcher = null, ScheduleLoopInterface $scheduleLoop = null, PsrClockInterface $clock = null, string $timezone = null)
+    public function __construct(ScheduleRunnerInterface $scheduleRunner, ScheduleLoaderInterface $loader, ?EventDispatcherInterface $dispatcher = null, ?ScheduleLoopInterface $scheduleLoop = null, ?PsrClockInterface $clock = null, ?string $timezone = null)
     {
         $this->scheduleRunner = $scheduleRunner;
         $this->loader = $loader;

diff --git a/src/Middleware/AsyncProcessEngine.php b/src/Middleware/AsyncProcessEngine.php
@@ -13,7 +13,7 @@ final class AsyncProcessEngine implements MiddlewareEngineInterface
 {
     private $tempDir;
 
-    public function __construct(string $sysTempDir = null)
+    public function __construct(?string $sysTempDir = null)
     {
         $this->tempDir = $sysTempDir ?: \sys_get_temp_dir();
     }

diff --git a/src/Middleware/ConsoleCommandEngine.php b/src/Middleware/ConsoleCommandEngine.php
@@ -22,7 +22,7 @@ final class ConsoleCommandEngine implements MiddlewareEngineInterface
      *
      * @param KernelInterface|null $kernel
      */
-    public function __construct(KernelInterface $kernel = null)
+    public function __construct(?KernelInterface $kernel = null)
     {
         $this->kernel = $kernel;
     }

diff --git a/src/Middleware/CronMiddlewareEngine.php b/src/Middleware/CronMiddlewareEngine.php
@@ -27,7 +27,7 @@ final class CronMiddlewareEngine implements MiddlewareEngineInterface
     private $lastLoopTasks = [];
     private $timers;
 
-    public function __construct(CronChecker $checker, string $timeZone = null, PsrClockInterface $clock = null, ScheduleLoopInterface $scheduleLoop = null, TimerStorage $timers = null)
+    public function __construct(CronChecker $checker, ?string $timeZone = null, ?PsrClockInterface $clock = null, ?ScheduleLoopInterface $scheduleLoop = null, ?TimerStorage $timers = null)
     {
         $this->timeZone = $timeZone;
         $this->checker = $checker;

diff --git a/src/Middleware/MessengerEngine.php b/src/Middleware/MessengerEngine.php
@@ -14,7 +14,7 @@ final class MessengerEngine implements MiddlewareEngineInterface
 {
     private $messageBus;
 
-    public function __construct(MessageBusInterface $messageBus = null)
+    public function __construct(?MessageBusInterface $messageBus = null)
     {
         $this->messageBus = $messageBus;
     }

diff --git a/src/Middleware/StackEngine.php b/src/Middleware/StackEngine.php
@@ -16,7 +16,7 @@ final class StackEngine implements StackInterface, MiddlewareEngineInterface
     /**
      * @param \Iterator|null $iterator
      */
-    public function __construct(\Iterator $iterator = null)
+    public function __construct(?\Iterator $iterator = null)
     {
         $this->iterator = $iterator;
     }

diff --git a/src/React/ReactLoopAdapter.php b/src/React/ReactLoopAdapter.php
@@ -21,7 +21,7 @@ class ReactLoopAdapter implements ScheduleLoopInterface
     private $loopTime;
     private $timeZone;
 
-    public function __construct(LoopInterface $loop = null, string $timeZone = null)
+    public function __construct(?LoopInterface $loop = null, ?string $timeZone = null)
     {
         $this->loop = $loop;
         $this->timeZone = $timeZone;
@@ -108,7 +108,7 @@ public function now(): \DateTimeImmutable
         return $now;
     }
 
-    public function setDefaultLoopTime(\DateTimeImmutable $loopTime = null): void
+    public function setDefaultLoopTime(?\DateTimeImmutable $loopTime = null): void
     {
         $this->loopTime = $loopTime;
     }

diff --git a/src/Runner/StandaloneLoop.php b/src/Runner/StandaloneLoop.php
@@ -14,7 +14,7 @@ class StandaloneLoop implements ScheduleLoopInterface
     protected $needSort = false;
     protected $running = false;
 
-    public function __construct(ClockInterface $clock = null, string $timeZone = null)
+    public function __construct(?ClockInterface $clock = null, ?string $timeZone = null)
     {
         $this->clock = $clock ?: new OkvpnLoopClock($timeZone);
     }