Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vapor): prevent adding prefix when prefixIdentifiers is false #12882

Closed
wants to merge 2 commits into from

Conversation

zhiyuanzmj
Copy link
Contributor

@zhiyuanzmj zhiyuanzmj commented Feb 17, 2025

jsx-vapor need this option.

Copy link

netlify bot commented Feb 17, 2025

Deploy Preview for vapor-repl ready!

Name Link
🔨 Latest commit 906882c
🔍 Latest deploy log https://app.netlify.com/sites/vapor-repl/deploys/67b28b72d9780b000818c1ee
😎 Deploy Preview https://deploy-preview-12882--vapor-repl.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@edison1105
Copy link
Member

edison1105 commented Feb 17, 2025

prefixIdentifiers: true,

There is no need to check prefixIdentifiers due to it is always true in compile-vapor

@zhiyuanzmj
Copy link
Contributor Author

Hi, I'm trying to upgrade jsx-vapor to this branch. jsx-vapor using the same generator to generate code.
I need set prefixIdentifiers to false to ensure that the id has no prefix.

image

@zhiyuanzmj
Copy link
Contributor Author

@edison1105 edison1105 added the scope: vapor related to vapor mode label Feb 17, 2025
@zhiyuanzmj zhiyuanzmj closed this Feb 17, 2025
@edison1105 edison1105 removed the scope: vapor related to vapor mode label Feb 17, 2025
@edison1105
Copy link
Member

use inline:true instead.

@zhiyuanzmj
Copy link
Contributor Author

use inline:true instead.

Fixed, Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants