Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(runtime-core): handle useTemplateRef multiple calls #12883

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

kovsu
Copy link
Contributor

@kovsu kovsu commented Feb 17, 2025

fix: #12754

Copy link

github-actions bot commented Feb 17, 2025

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 101 kB (+70 B) 38.1 kB (+32 B) 34.3 kB (-5 B)
vue.global.prod.js 158 kB (+70 B) 58 kB (+26 B) 51.6 kB (+28 B)

Usages

Name Size Gzip Brotli
createApp (CAPI only) 46.5 kB 18.2 kB 16.7 kB
createApp 54.6 kB 21.3 kB 19.4 kB
createSSRApp 58.8 kB 23 kB 21 kB
defineCustomElement 59.4 kB 22.9 kB 20.8 kB
overall 68.6 kB 26.4 kB 24 kB

Copy link

pkg-pr-new bot commented Feb 17, 2025

Open in Stackblitz

@vue/compiler-core

npm i https://pkg.pr.new/@vue/compiler-core@12883

@vue/compiler-dom

npm i https://pkg.pr.new/@vue/compiler-dom@12883

@vue/compiler-ssr

npm i https://pkg.pr.new/@vue/compiler-ssr@12883

@vue/compiler-sfc

npm i https://pkg.pr.new/@vue/compiler-sfc@12883

@vue/reactivity

npm i https://pkg.pr.new/@vue/reactivity@12883

@vue/runtime-core

npm i https://pkg.pr.new/@vue/runtime-core@12883

@vue/runtime-dom

npm i https://pkg.pr.new/@vue/runtime-dom@12883

@vue/server-renderer

npm i https://pkg.pr.new/@vue/server-renderer@12883

@vue/shared

npm i https://pkg.pr.new/@vue/shared@12883

vue

npm i https://pkg.pr.new/vue@12883

@vue/compat

npm i https://pkg.pr.new/@vue/compat@12883

commit: 044b4d8

@edison1105 edison1105 added need test The PR has missing test cases. ready for review This PR requires more reviews labels Feb 17, 2025
@edison1105 edison1105 changed the title fix(runtime-core): key check in useTemplateRef fix(runtime-core): handle useTemplateRef multiple calls Feb 17, 2025
@edison1105 edison1105 added ready to merge The PR is ready to be merged. 🍰 p2-nice-to-have Priority 2: this is not breaking anything but nice to have it addressed. and removed need test The PR has missing test cases. ready for review This PR requires more reviews labels Feb 17, 2025
@edison1105 edison1105 removed the ready to merge The PR is ready to be merged. label Feb 17, 2025
@edison1105 edison1105 added the ready to merge The PR is ready to be merged. label Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍰 p2-nice-to-have Priority 2: this is not breaking anything but nice to have it addressed. ready to merge The PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

calling useTemplateRef a second time for the same ref errors on prod
2 participants