docs: add composition api to style-guide #2585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vuejs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Shinigami92
force-pushed
the
docs-add-composition-style-guide
branch
4 times, most recently
from
20f8297 to
5fc2004
Compare
Shinigami92
force-pushed
the
docs-add-composition-style-guide
branch
from
5fc2004 to
640b268
Compare
NataliaTepluhina
approved these changes
Nov 30, 2023
There was a problem hiding this comment.
@Shinigami92 thank you for the great contribution! Looks great to me, approved 👍🏻
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Problem
We had issues with some juniors in our company and told them to read the style-guide section about how to handle props and emits between parent and child components,
but then we found out that there are no composition api examples in that section
The juniors only know Vue 3 and don't know the "old" options-api
Proposed Solution
Add composition-api style-guide examples
Additional Information
I'm using TypeScript here, please let me know if I should rewrite the examples to plain JavaScriptAll docs around the style-guide uses JavaScript, so I used JS as well