revert traversing data function, it does not use assigning template r…

…efs to variables
vuejs · Nov 2, 2024 · b56d81e · b56d81e
1 parent b598f30
commit b56d81e
Show file tree

Hide file tree

Showing 2 changed files with 51 additions and 62 deletions.
diff --git a/lib/rules/prefer-use-template-ref.js b/lib/rules/prefer-use-template-ref.js
@@ -66,22 +66,6 @@ module.exports = {
           }
         }
       ),
-      utils.executeOnVue(context, (obj) => {
-        const properties = utils.iterateProperties(obj, new Set(['data']))
-        for (const node of properties) {
-          // @ts-ignore
-          if (!expressionIsRef(node.property.value)) {
-            return
-          }
-
-          scriptRefs.push({
-            // @ts-ignore
-            node: node.property.value,
-            // @ts-ignore
-            ref: node.property.key.name
-          })
-        }
-      }),
       {
         'Program:exit'() {
           for (const templateRef of templateRefs) {

diff --git a/tests/lib/rules/prefer-use-template-ref.js b/tests/lib/rules/prefer-use-template-ref.js
@@ -115,7 +115,7 @@ tester.run('prefer-use-template-ref', rule, {
       `
     },
     {
-      filename: 'options-api.vue',
+      filename: 'options-api-no-refs.vue',
       code: `
       <template>
         <label ref="label">
@@ -126,7 +126,7 @@ tester.run('prefer-use-template-ref', rule, {
         <button
       </template>
       <script>
-        import { useTemplateRef } from 'vue';
+        import { ref } from 'vue';
         export default {
           name: 'NameRow',
           methods: {
@@ -138,8 +138,8 @@ tester.run('prefer-use-template-ref', rule, {
           }
           data() {
             return {
-              label: useTemplateRef('label'),
-              name: ref('')
+              label: 'label',
+              name: ''
             }
           },
           computed: {
@@ -150,6 +150,53 @@ tester.run('prefer-use-template-ref', rule, {
         }
       </script>
       `
+    },
+    {
+      filename: 'options-api-mixed.vue',
+      code: `
+      <template>
+        <label ref="labelElem">
+          Name:
+          <input v-model="name" />
+        </label>
+        {{ loremIpsum }}
+      </template>
+      <script>
+        import { ref } from 'vue';
+        export default {
+          name: 'NameRow',
+          props: {
+            defaultLabel: {
+              type: String,
+            },
+          },
+          data() {
+            return {
+              label: ref(this.defaultLabel),
+              labelElem: ref(),
+              name: ''
+            }
+          },
+          computed: {
+            loremIpsum() {
+              return this.name + ' lorem ipsum'
+            }
+          }
+        }
+      </script>
+      `
+    },
+    {
+      filename: 'template-ref-function.vue',
+      code: `
+      <template>
+        <button :ref="ref => button = ref">Content</button>
+      </template>
+      <script setup>
+        import { ref } from 'vue';
+        const button = ref();
+        </script>
+      `
     }
   ],
   invalid: [
@@ -271,48 +318,6 @@ tester.run('prefer-use-template-ref', rule, {
           column: 28
         }
       ]
-    },
-    {
-      filename: 'options-api-only-refs.vue',
-      code: `
-      <template>
-        <label ref="labelElem">
-          Name:
-          <input v-model="name" />
-        </label>
-        {{ loremIpsum }}
-      </template>
-      <script>
-        import { ref } from 'vue';
-        export default {
-          name: 'NameRow',
-          props: {
-            defaultLabel: {
-              type: String,
-            },
-          },
-          data() {
-            return {
-              label: ref(this.defaultLabel),
-              labelElem: ref(),
-              name: ref('')
-            }
-          },
-          computed: {
-            loremIpsum() {
-              return this.name + ' lorem ipsum'
-            }
-          }
-        }
-      </script>
-      `,
-      errors: [
-        {
-          messageId: 'preferUseTemplateRef',
-          line: 21,
-          column: 26
-        }
-      ]
     }
   ]
 })