-
-
Notifications
You must be signed in to change notification settings - Fork 668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new option to specify tags to ignore vue/no-deprecated-slot-attribute
#2314
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I guess this makes sense. I have some comments though. Thanks for your contribution!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🙂
@FloEdelmann @ota-meshi |
I need to review, merge and release this PR, but I don't have time to do that now 😓 |
@ota-meshi Thank you for the reply. If so, it's fine when you have time.🙆♂️ Just wanted to check on the status. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The implementation looks good to me. Could you add documentation for the new option?
@ota-meshi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you!
closes: #2313
I have not yet updated the documentation for this rule. If the content of this PR and issue is accepted, I will start working on those.