Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nuxt): ensure payload plugin declaration is generated #2806

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

danielroe
Copy link
Member

follow-up on e645fc1

currently this emits an empty plugin declaration file - you can see the following warning in the build:

src/runtime/payload-plugin.ts(11,7): error TS2742: The inferred type of 'payloadPlugin' cannot be named without a reference to '.pnpm/[email protected]_@[email protected]_@[email protected][email protected][email protected]_magicast@0_xnetk5q47sjylsz3dxwz7c7qre/node_modules/nuxt/app'. This is likely not portable. A type annotation is necessary.

see nuxt/module-builder#141 (comment)

Copy link

netlify bot commented Oct 25, 2024

Deploy Preview for pinia-official canceled.

Name Link
🔨 Latest commit 3c778bd
🔍 Latest deploy log https://app.netlify.com/sites/pinia-official/deploys/671b71e4a7ccca00096d872c

Copy link

netlify bot commented Oct 25, 2024

Deploy Preview for pinia-playground canceled.

Name Link
🔨 Latest commit 3c778bd
🔍 Latest deploy log https://app.netlify.com/sites/pinia-playground/deploys/671b71e4a7ccca00096d8730

Copy link

codecov bot commented Oct 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.24%. Comparing base (6fb480e) to head (3c778bd).

Additional details and impacted files
@@            Coverage Diff             @@
##               v2    #2806      +/-   ##
==========================================
+ Coverage   89.67%   91.24%   +1.57%     
==========================================
  Files          14       14              
  Lines        1336     1336              
  Branches      218      222       +4     
==========================================
+ Hits         1198     1219      +21     
+ Misses        137      115      -22     
- Partials        1        2       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

pkg-pr-new bot commented Oct 25, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/@pinia/nuxt@2806
pnpm add https://pkg.pr.new/pinia@2806
pnpm add https://pkg.pr.new/@pinia/testing@2806

commit: 3c778bd

@danielroe danielroe requested a review from posva October 25, 2024 10:27
Copy link
Member

@posva posva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@posva posva merged commit 99ab76c into v2 Oct 25, 2024
10 checks passed
@posva posva deleted the fix/payload-plugin-types branch October 25, 2024 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants