Skip to content

Commit

Permalink
chore[ci]: improve coverage jobs (#4457)
Browse files Browse the repository at this point in the history
This commit makes minor improvements to the coverage CI:
1. Consolidate upload of coverage artifacts into a single step
2. Change `file` field to `files` for `codecov-action@v5`

references:
- https://github.com/codecov/codecov-action?tab=readme-ov-file#migration-guide

---------

Co-authored-by: Charles Cooper <[email protected]>
  • Loading branch information
tserg and charles-cooper authored Jan 21, 2025
1 parent 4d693b7 commit 762eec6
Showing 1 changed file with 8 additions and 12 deletions.
20 changes: 8 additions & 12 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -271,20 +271,16 @@ jobs:
run: |
coverage xml
- name: Upload coverage sqlite artifact
- name: Upload coverage artifacts
# upload coverage sqlite db for debugging
# upload coverage.xml artifact for downstream codecov upload action
uses: actions/upload-artifact@v4
with:
name: coverage-sqlite
name: coverage-artifacts
include-hidden-files: true
path: .coverage
if-no-files-found: error

- name: Upload coverage.xml
uses: actions/upload-artifact@v4
with:
name: coverage-xml
path: coverage.xml
path: |
.coverage
coverage.xml
if-no-files-found: error

upload-coverage:
Expand All @@ -296,10 +292,10 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/download-artifact@v4
with:
name: coverage-xml
name: coverage-artifacts

- name: Upload Coverage
uses: codecov/codecov-action@v5
with:
token: ${{ secrets.CODECOV_TOKEN }}
file: coverage.xml
files: coverage.xml

0 comments on commit 762eec6

Please sign in to comment.