fix[codegen]: fix assertions for certain precompiles #4451
Merged
+257
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in 93a9579, the assert for memory copying calls to the identity precompile was optimized out; the reasoning being that if the identity precompile fails due to OOG, the caller contract would also likely fail with OOG. however, due to the 63/64ths rule, there are cases where the identity precompile could fail with OOG, but the caller contract has enough gas to successfully return out of the call context. (note that even prior to 93a9579, some calls to the identity precompile did not check the success flag. cf. commit cf03d27). this only affects pre-cancun compilation targets, since post-cancun the `mcopy` instruction is chosen. this commit fixes the identity precompile call for pre-cancun targets. a similar optimization was also applied in the past to omit the check when calling the ecrecover precompile. a check for the ecrecover call is applied in this commit. while this is a performance regression, ecrecover is generally not a hotspot; as for the identity precompile, it is only used by the compiler for memory copies pre-cancun, so the performance regression there is not too relevant (as of nov 2024).
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4451 +/- ##
=======================================
Coverage 92.01% 92.01%
=======================================
Files 119 119
Lines 16692 16692
Branches 2805 2805
=======================================
Hits 15359 15359
Misses 915 915
Partials 418 418 ☔ View full report in Codecov by Sentry. |
|
aren't the tests using |
gas_used - 1 will always revert. we want to supply enough gas that the inner call will return 0 but the outer call will not oog.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
cyberthirst
reviewed
Jan 19, 2025
| # check deploy IR (which contains runtime IR) | ||
| ir_node = CompilerData(source_code).ir_nodes | ||
|
|
||
| def _check(ir_node, parent=None): |
There was a problem hiding this comment.
i think it would be better to assert that one of the nodes is staticcall and assert that it calls a precompile address
There was a problem hiding this comment.
and once we establish this is true, assert that the parent is assert
There was a problem hiding this comment.
hmm i guess this was motivated by making this general even for cancun. but still i'd change the code and handle this on callsite
cyberthirst
reviewed
Jan 19, 2025
cyberthirst
reviewed
Jan 19, 2025
cyberthirst
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
fix for GHSA-vgf2-gvx8-xwc3
How I did it
How to verify it
Commit message
Description for the changelog
Cute Animal Picture