Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add accessibility section #127

Merged
merged 1 commit into from
Mar 12, 2024
Merged

Add accessibility section #127

merged 1 commit into from
Mar 12, 2024

Conversation

darktears
Copy link
Contributor

@darktears darktears commented Mar 11, 2024 •
edited by pr-preview bot
Loading

Closes #70

Preview | Diff

kenchris
kenchris reviewed Mar 12, 2024
View reviewed changes
index.html Outdated Show resolved Hide resolved
kenchris
kenchris reviewed Mar 12, 2024
View reviewed changes
index.html Outdated Show resolved Hide resolved
kenchris
kenchris reviewed Mar 12, 2024
View reviewed changes
index.html Outdated Show resolved Hide resolved
kenchris
kenchris reviewed Mar 12, 2024
View reviewed changes
index.html Outdated Show resolved Hide resolved
kenchris
kenchris reviewed Mar 12, 2024
View reviewed changes
index.html Outdated Show resolved Hide resolved
kenchris
kenchris reviewed Mar 12, 2024
View reviewed changes
index.html Outdated Show resolved Hide resolved
kenchris
kenchris reviewed Mar 12, 2024
View reviewed changes
index.html Outdated Show resolved Hide resolved
kenchris
kenchris reviewed Mar 12, 2024
View reviewed changes
index.html Outdated Show resolved Hide resolved
kenchris
kenchris reviewed Mar 12, 2024
View reviewed changes
index.html Outdated Show resolved Hide resolved
kenchris
kenchris reviewed Mar 12, 2024
View reviewed changes
index.html Outdated Show resolved Hide resolved
kenchris
kenchris reviewed Mar 12, 2024
View reviewed changes
index.html Outdated Show resolved Hide resolved
kenchris
kenchris reviewed Mar 12, 2024
View reviewed changes
index.html Outdated Show resolved Hide resolved
kenchris
kenchris reviewed Mar 12, 2024
View reviewed changes
index.html Outdated Show resolved Hide resolved
kenchris
kenchris reviewed Mar 12, 2024
View reviewed changes
index.html Outdated Show resolved Hide resolved
kenchris
kenchris reviewed Mar 12, 2024
View reviewed changes
index.html Outdated Show resolved Hide resolved
kenchris
kenchris reviewed Mar 12, 2024
View reviewed changes
index.html Show resolved Hide resolved
@darktears darktears merged commit 1e8e279 into w3c:gh-pages Mar 12, 2024
2 checks passed
rakuco
rakuco reviewed Mar 12, 2024
View reviewed changes
Copy link
Member

@rakuco rakuco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added some inline comments with proof-reading suggestions.

Other than that: I see no mention of point (2) of #70, was it added elsewhere?

I'd also thank the APA (or the specific reviewer) in the Acknowledgments section.

index.html Show resolved Hide resolved
index.html Show resolved Hide resolved
index.html Show resolved Hide resolved
index.html Show resolved Hide resolved
index.html Show resolved Hide resolved
index.html Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rakuco rakuco rakuco left review comments

@kenchris kenchris kenchris approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Requesting Accessibility Considerations section
3 participants
@darktears @rakuco @kenchris