-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Datagen_Project #980
Datagen_Project #980
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the application. Milestone 1 and 2 currently seem relatively expensive to me. I guess you are simply reusing the babe implementation for this one and not implementing your own randomness implementation. Is this correct? At the moment it looks like you want to have 10k per function that you are going to implement. Could you add additional functionality or reduce the price? Regarding the Web Dapp, we usually ask teams to provide some initial designs or mock-ups for front-end focused deliveries. Could you add this? Unless you are simply reusing the substrate front-end template for this.
Well'll revert back ASAP in the next few days. |
Hi @Noc2 Datagen developer here! For the Milestone 1 we want to develop a pallet to manage the random selection of the nodes that have to check if the computational work (from other random selected nodes) has been done correctly. So I think we need a custom pallet to manage the logic for this mechanism, maybe we could start with the babe pallet and modify it. Let me know if it makes sense to you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the quick reply. Yes, you need to develop your own pallet for this. You should probably take a look at
https://docs.substrate.io/how-to-guides/v3/pallet-design/randomness/
https://github.com/paritytech/substrate/blob/master/frame/babe/src/randomness.rs
I was mostly referring to the fact that the pallet at the moment seems to have only a single function according to the milestone, correct? And therefore it seems relatively expensive, so I would recommend either adding additional details to the delivery or reduce the price a little bit.
I’m closing the application due to inactivity. Let me know if I should reopen it. |
@Noc2 , you asked us to create a mock-up. It required some days. We were also updating the Milestones as requested. We were waiting to have the mock-up to update all in one shot. OF COURSE you should reopen it. |
Got it. I wasn’t sure you are working on it, since you didn’t reply for 18 days. I will reopen the PR. |
Thank you very much @Noc2 , yea, sorry for not answering, we directly went back to work ... for us was implied that we were going to answer once we had updated the grant proposal, taking into account of all your suggestions. Sorry for not notifying that to you. :) |
Hi @Noc2! For milestones 1 and 2 we add more functionalities and explain them more in depth. If there are more things to change let us know :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update. @viac92 could you also sign the CLA? All contributors need to sign it. Apart from this, I’m happy to support the project.
Oh sure, I sign it now btw thank you @Noc2 for the approval! |
Hi @Noc2, one question, when we submitted the grant, it was a lev.2 (as you can see in the Project Abstract above). I think that rules were changed while our proposal was pending. I asked Monday for some clarification from @SBalaguer and he seems to confirm that you changed the rules in the meantime. Is it possible to have some clarification even here on the grant proposal? Many Thanks. |
Yes, correct. We changed the levels, but everyone who applied before the github commit, still needs the same number of approvals as before. So in your case 3 approvals. |
Thank you for the clarification @Noc2 , glad to hear it. So we don't have to worry about the fact that in the right-upper part of the screen I see: "At least 5 approving reviews are required to merge this pull request." ? As so, once we have three approvals the proposal is passed? Do you want us to remember you to do that manually if we have the three approvals (since it is different from the general status of new applications)? |
Yes, you don’t need to worry about the 5 approvals. This is just because the github branch protection works like this. We will merge the application after three approvals. |
Grazie mille. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the application, @Lord-Nymphis. Could you please replace the screenshots in the specifications under M3 with a list of functions or functionalities, so it's less ambiguous what is being delivered?
@semuelle in a nutshell is not so different from a scan. Once you have installed the local blockchains (both heavy and fast) and once they are both producing blocks, will be possible to search for specific blocks or nodes and see (in the specific case of the fast blockchain), accordingly to the consensus protocol, how many nodes have been checked, when, and by what other node. Some info is visible in the home, with sheets that are scrolling while new blocks are generated, some other info (about any specific block, at any height) can be searched for example simply selecting the hight of the block (after inputting the filter for the blockchain "fast" or "heavy"). We'll write clear comment in the milestone M3 sheet. |
Hi @Lord-Nymphis are you still planning on submitting a delivery soon? |
Hi @keeganquigley , we are planning to deliver soon, by mid December. The bridge setup is completed, we are finishing to complete the RPC methods. |
Hi @Lord-Nymphis any updates you can provide? |
Ciao @keeganquigley , someone in the Parity team had the wonderful idea of discontinuing ( paritytech/parity-bridges-common#2663 (review) ) the Rialto Millau bridge repo, over which we had built the core functionalities of our solochain to parachain bridge. Thanks to that, we throw away a couple hundred hours of development and we had to refactor the entirety of our core functionalities (shifting to Westend - Rococo), which we are finishing to do. Most of the refactoring had been done, but we are still getting some error when running the setup. We are working to fix everything. |
Thanks for the update @Lord-Nymphis I appreciate you informing us on the situation. I will take note of this and consult with the team, perhaps we should create a new RFP to find a team who is willing to take over and maintain these bridges. LMK if that is something your team would be interested in. |
Thanks. BTW our dev heard one of Parity devs that worked on the Rialto repo and told us it would have been outdated with the new SDK. Now we already refactored almost everything. |
Hi @Lord-Nymphis how did the refactoring go? Can you provide any updates? |
Hi @keeganquigley , thank you for asking! The part concerning the heavy chain's refactoring is done and the blockchain is compiling, the part concerning the fast chain is still missing some features for some dependencies concerning the runtime, but they could potentially be fixed by the end of this weekend. After that the refactoring is done, with of course the bridge implementation to be done after that. |
Hi @Lord-Nymphis any updates? I see that the two grant repos mentioned above haven't had any commits in around 6 months. |
Hi @keeganquigley . Yep. I think you have been looking into some old branches. The last update is two days ago. Here the most updated code branch https://github.com/Datagen-Project/Datagen-Substrate-Grant/tree/ln-update-testing-bridge |
Thanks for the update @Lord-Nymphis does this mean a delivery will be submitted soon? |
pinging @Lord-Nymphis |
Yes. Sorry for not answering, the message slipped through. |
Hi @Lord-Nymphis seeing as the delivery date keeps getting pushed, and there has been no delivery for a year and half, it's probably best to go ahead and close it at this point, and it can potentially be re-opened in the future should you wish to submit a delivery. This helps us for administrative & budgeting purposes. Let me know if this works, otherwise we'll close it in a few days. Thanks! |
Hi @keeganquigley , as previously explained, the company had budget constraints during the bear market and we had to change a few devs. There had been also the matter of Parity discontinuing the support for the Rialto-Millau bridge repositories in November 2023 for the new SDK, meaning that we had to do everything from scratch starting from that date using the Rococo-Westend bridges. Happy to help you with your administrative budgeting as long as this doesn't require going again through the approval procedure from the grant commission. Let me know the best way to go ahead with this. |
Thanks @Lord-Nymphis for the update. Is this dev already listed on the application as part of the team? Usually for core contributors we ask for any personnel changes to be amended on the original document. |
@keeganquigley No, he is not. The dev is the one that made the most recent contributions in this repo's branch https://github.com/Datagen-Project/Datagen-Substrate-Grant/tree/ln-update-testing-bridge Now he is on leave for personal reasons. He should come back in 8 days. What do you think, could we directly update the application document right before pushing the code for the milestone? We also had another dev making some small contributions in December and we don't exclude to have others helping the current one with other contributions; to avoid updating the document multiple times and to have something more complete in terms of contributors, we could update right before submitting the Milestone code. |
Sounds good, thanks @Lord-Nymphis let me consult with the team and will get back to you! |
Hi @Lord-Nymphis thanks for your patience while we discussed internally; unfortunately the committee has unanimously decided to cancel the grant, mainly for the following reasons:
That being said, we thank you for all the time & effort you've put into this project and we wish you the best of luck in finding funding moving forward. |
We would like to know the procedure to reapply for the milestone delivery once delivered. Thanks |
Sure thing @Lord-Nymphis yes it can always potentially be re-opened in the future should you have a delivery ready for submission. The procedure would essentially be the same as the regular application process, but in your case you would submit a PR to amend the contract to remove the terminated status. I hope that helps! |
@keeganquigley so basically it's like the milestone it's in standby? |
We would need to submit only the delivery or the application? |
Yes, in this scenario you would need to submit two PRs, one for the application and one for the delivery. However it probably wouldn't be necessary to submit another application entirely, as the current one will stay in our files, but with the added status. So you would just submit a PR amendment to change the status. |
So I will basically submit a pull request where I submit the Milestone (as per deliverable of the closed grant) and the request to reopen the Grant and approve the Milestone, all in the sam PR? |
@Lord-Nymphis I'm not sure what you mean here, since deliveries are submitted to the milestone delivery repo, while applications are submitted to the grants repo. But seeing as the grant is now closed, we aren't currently able to accept any future deliveries. Therefore you would need to first submit a PR to request that it be re-opened. Please note, however, that the committee will likely take this termination into account as part of any future decisions. |
@keeganquigley Yes, it's clear we don't have to submit the delivery in the milestone repo, but that the right procedure is to submit the application to the grant repo. What I meant (ofc I have clear that the procedure requires the voting of the commission) is that, exactly because there had been delays with the delivery of the second milestone of the closed grant, it's pretty obvious that if we submit the application proposal without any viable code it would be rejected (I can't read in the committee's members' minds, ofc, but I presume it would be only logical), as so we would like to submit the application to the grant repo (requesting to re-open) together with the complete delivery of the second milestone of the previously closed grant, in good faith (understanding that then 1. the committee would have to update the grant status 2. only subsequently to the eventual acceptance of the status the milestone delivery could be approved). Please let me know if this logic resonates |
Regarding #980 (comment) While we acknowledge that you are 100% right about us being late and we take full responsibility on this specific matter, and I understand that this point alone is sufficient for you to change the grant status, I would also like to underline that there has been NO undocumented changes in scope in the grant deliveries. This is a factual error, which I would like to challenge (if I am mistaken, I would like to know in what regard). |
Also regarding this specific comment in the post #980 (comment)
I would like to underline that this is another factual error, given that our most recent code branch https://github.com/Datagen-Project/Datagen-Substrate-Grant/tree/ln-update-testing-bridge/heavy_blockchain/node/src It's clear that, unfortunately, we had deeply underestimated the task when submitting the grant proposal. I understand that you have a variety of problems with the restructuring of Parity and the W3F, but, at the same time, you can't expect small project to do the impossible and take the scorn. I understand that you had already voted on the matter and that clearly for the W3F moving 12K from one row of the balance sheet to another is more important that retaining projects and having development for Substrate, so I don't expect you to reconsider. I also understand that this isn't your fault, but that this is the policy of the W3F. I only hope that these considerations will be taken into account when we will submit the PR (together with the code) in good faith. Have a good day |
Project Abstract
B-Datagray’s Datagen project concerns the development of a decentralized infrastructure for CPU/GPU cloud computing, in chain, through different blockchain components.
The Datagen infrastructure requires the creation of a Substrate-based blockchain with some key features: low latency time, high efficiency (compatibly with the decentralized nature of the network), high degree of decentralization (higher than a traditional PoS would allow) of the physical hardware providing the cloud computing (therefore requiring a customized consensus protocol) and in-chain (or near-in-chain) computation (no off-chain based solutions).
The Datagen infrastructure primarily want to serve: privacy friendly search engines and browsers, decentralized Web3 games and other ones (for example decentralizing the hardware layer of PoS blockchains, typically hosted on AWS and similar, etc…).
We will implement only a PoC with this grant.
The goal is to achive a fully functional mechanism for the random selection of the nodes in the fast blockchian and smooth communication between the two blockchains.
For which grant level are you applying?
Application Checklist
project_name.md
) and updated.@_______
How Did You Hear About our grants program?