-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation of Olaf #104
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,3 +11,4 @@ Cargo.lock | |
*.bak | ||
|
||
*.s | ||
.DS_Store |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
# Basic | ||
edition = "2021" | ||
max_width = 100 | ||
use_small_heuristics = "Max" | ||
|
||
# Imports | ||
imports_granularity = "Preserve" | ||
reorder_imports = false | ||
reorder_modules = false | ||
|
||
# Consistency | ||
newline_style = "Unix" | ||
|
||
# Misc | ||
chain_width = 80 | ||
spaces_around_ranges = false | ||
reorder_impl_items = false | ||
match_arm_leading_pipes = "Preserve" | ||
match_arm_blocks = false | ||
match_block_trailing_comma = true | ||
trailing_comma = "Vertical" | ||
# trailing_semicolon = false | ||
# use_field_init_shorthand = true | ||
|
||
# where_single_line = true # does not work on fn | ||
# brace_style = "AlwaysNextLine" # does not work on method fn | ||
|
||
# Format comments | ||
comment_width = 100 | ||
wrap_comments = true | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -22,17 +22,25 @@ curve25519-dalek = { version = "4.1.0", default-features = false, features = [ | |
"zeroize", | ||
"precomputed-tables", | ||
"legacy_compatibility", | ||
"rand_core", | ||
"serde", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. How is rand_core being added as a feature? rand_core is not an ptional dependency There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I am not sure, does it have to be? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. rand_core is mandatory. why is this feature being added? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Because without it it does not compile, I don't know why. |
||
] } | ||
subtle = { version = "2.4.1", default-features = false } | ||
merlin = { version = "3.0.0", default-features = false } | ||
getrandom_or_panic = { version = "0.0.3", default-features = false } | ||
rand_core = { version = "0.6.2", default-features = false } | ||
serde_crate = { version = "1.0.130", package = "serde", default-features = false, optional = true } | ||
serde = { version = "1.0.130", default-features = false, optional = true } | ||
serde_bytes = { version = "0.11.5", default-features = false, optional = true } | ||
cfg-if = { version = "1.0.0", optional = true } | ||
sha2 = { version = "0.10.7", default-features = false } | ||
failure = { version = "0.1.8", default-features = false, optional = true } | ||
zeroize = { version = "1.6", default-features = false, features = ["zeroize_derive"] } | ||
zeroize = { version = "1.6", default-features = false, features = [ | ||
"zeroize_derive", | ||
] } | ||
derive-getters = "0.3.0" | ||
chacha20poly1305 = { version = "0.10.1", default-features = false } | ||
hex = { version = "0.4", default-features = true, optional = true } | ||
thiserror = { version = "1.0", default-features = false, optional = true } | ||
|
||
[dev-dependencies] | ||
rand = "0.8.5" | ||
|
@@ -47,17 +55,39 @@ serde_json = "1.0.68" | |
name = "schnorr_benchmarks" | ||
harness = false | ||
|
||
[[bench]] | ||
name = "olaf_benchmarks" | ||
required-features = ["alloc", "aead"] | ||
|
||
[features] | ||
std = [ | ||
"alloc", | ||
"getrandom", | ||
"serde_bytes/std", | ||
"rand_core/std", | ||
"getrandom_or_panic/std", | ||
"chacha20poly1305/std", | ||
"hex/std", | ||
"thiserror", | ||
] | ||
default = ["std", "getrandom"] | ||
preaudit_deprecated = [] | ||
nightly = [] | ||
alloc = ["curve25519-dalek/alloc", "rand_core/alloc", "getrandom_or_panic/alloc", "serde_bytes/alloc"] | ||
std = ["alloc", "getrandom", "serde_bytes/std", "rand_core/std", "getrandom_or_panic/std"] | ||
alloc = [ | ||
"curve25519-dalek/alloc", | ||
"rand_core/alloc", | ||
"getrandom_or_panic/alloc", | ||
"serde_bytes/alloc", | ||
] | ||
asm = ["sha2/asm"] | ||
serde = ["serde_crate", "serde_bytes", "cfg-if"] | ||
serde = ["dep:serde", "serde_bytes", "cfg-if"] | ||
# We cannot make getrandom a direct dependency because rand_core makes | ||
# getrandom a feature name, which requires forwarding. | ||
getrandom = ["rand_core/getrandom", "getrandom_or_panic/getrandom", "aead?/getrandom"] | ||
getrandom = [ | ||
"rand_core/getrandom", | ||
"getrandom_or_panic/getrandom", | ||
"aead?/getrandom", | ||
] | ||
# We thus cannot forward the wasm-bindgen feature of getrandom, | ||
# but our consumers could depend upon getrandom and activate its | ||
# wasm-bindgen feature themselve, which works due to cargo features | ||
|
@@ -66,3 +96,4 @@ getrandom = ["rand_core/getrandom", "getrandom_or_panic/getrandom", "aead?/getra | |
# See https://github.com/rust-lang/cargo/issues/9210 | ||
# and https://github.com/w3f/schnorrkel/issues/65#issuecomment-786923588 | ||
aead = ["dep:aead"] | ||
cheater-detection = [] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your git GUI has seemingly pulled recent changes from master into its own commit. I'd expect git handles this fine, likely disapears once rebased onto master, but it's odd behavior that indicates issues with the git GUI.
Did you make any other changes to this PR since 25 April?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I messed up...Pushed some changes directly to master instead of this branch and then pulled them.