Feature#7.1 Update #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merge 오류가 나서 수정했습니다
gyusang
reviewed
Dec 29, 2020
gyusang
reviewed
Dec 29, 2020
This was
linked to
issues
Dec 29, 2020
Open
yuri-0415
force-pushed
the
Feature/#7.1
branch
from
ff72dda to
ca9d21e
Compare
yuri-0415
force-pushed
the
Feature/#7.1
branch
from
c2560bd to
2a7abcd
Compare
|
상규님 수정사항 반영했습니다! |
gyusang
requested changes
Jan 2, 2021
gyusang
reviewed
Jan 2, 2021
wadium/user/views.py
Outdated
|
|
||
| def list(self, request): | ||
| username = request.query_params.get('username') | ||
| users = self.get_queryset().filter(username__icontains=username) |
There was a problem hiding this comment.
users = users.select_related('userprofile').prefetch_related('emails') 등으로 N+1 문제를 완화하면 좋겠습니다.
gyusang
requested changes
Jan 3, 2021
gyusang
requested changes
Jan 3, 2021
merge 하면 될까요? |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
merge 오류가 나서 수정했습니다