-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get up-to-date #132
Merged
Merged
Get up-to-date #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add tutorial test case. * Add test case. This time with the decorator.
* Warn if we can't find the iterable definition. * Fix comment. * Actually check parameters. * Add interprocedural dataset test. * Fallback to interprocedal analysis for datasets. If the dataset iterable can't be found using intraprodecudral analysis, use interprocedural. * Apply spotless. * Add a hybrid dataset test case. * Actually check the parameter value numbers.
* Change log from warning to info. * Avoid adding non-scalar datasets as tensor sources. Instead, we want to add their constituent elements (fields). * Add support for non-scalar datasets. * Add interprocedural test case.
It's only non-scalar if it's on the LHS of the property reads.
Let's know whent his occurs.
* Add neural network test. * New tests. * Change log message. * Add Dataset.repeat(). * Add log. * Add prefetch. * Add Dataset.take(). * Add tf.nn.softmax(). * Add the ability to process datasets coming out of enumerate().
* Only function parameters. * Add space. * Use static import.
* Only function parameters. * Add space. * Use static import. * Separate tests by calling contexts. Currently, we are considering all calling contexts. We now check each one separately. The test parameters now make more sense, but the downside is that now all calls must be consistent. This may cause problems because Python supports union types. I've disabled one test due to this problem, but it's not caused by union types but rather a bug in the tensor dataflow tracking. * Apply spotless.
Doesn't always work due to wala#127.
It's not dependent on that.
* Check the context/function PK mappings. We need at least one if we are expecting at least one tensor parameter.
khatchad
added
bug
Something isn't working
enhancement
New feature or request
cleanup
labels
Jan 29, 2024
…tensor dataflow sources. Don't process an instruction more than once during recursive calls.
Prevent infinite recursion when processing instructions when finding tensor dataflow sources.
msridhar
approved these changes
Jan 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did not do a deep review, but LGTM :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry for the large update.