Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get up-to-date #132

Merged
merged 38 commits into from
Jan 30, 2024
Merged

Get up-to-date #132

merged 38 commits into from
Jan 30, 2024

Conversation

khatchad
Copy link
Collaborator

@khatchad khatchad commented Jan 29, 2024

Sorry for the large update.

khatchad and others added 30 commits January 29, 2024 12:59
* Add tutorial test case.

* Add test case.

This time with the decorator.
* Warn if we can't find the iterable definition.

* Fix comment.

* Actually check parameters.

* Add interprocedural dataset test.

* Fallback to interprocedal analysis for datasets.

If the dataset iterable can't be found using intraprodecudral analysis, use interprocedural.

* Apply spotless.

* Add a hybrid dataset test case.

* Actually check the parameter value numbers.
* Change log from warning to info.

* Avoid adding non-scalar datasets as tensor sources.

Instead, we want to add their constituent elements (fields).

* Add support for non-scalar datasets.

* Add interprocedural test case.
It's only non-scalar if it's on the LHS of the property reads.
Let's know whent his occurs.
* Add neural network test.

* New tests.

* Change log message.

* Add Dataset.repeat().

* Add log.

* Add prefetch.

* Add Dataset.take().

* Add tf.nn.softmax().

* Add the ability to process datasets coming out of enumerate().
* Only function parameters.

* Add space.

* Use static import.
* Only function parameters.

* Add space.

* Use static import.

* Separate tests by calling contexts.

Currently, we are considering all calling contexts. We now check each one separately. The test parameters now make more sense, but the downside is that now all calls must be consistent. This may cause problems because Python supports union types. I've disabled one test due to this problem, but it's not caused by union types but rather a bug in the tensor dataflow tracking.

* Apply spotless.
Doesn't always work due to wala#127.
* Check the context/function PK mappings.

We need at least one if we are expecting at least one tensor parameter.
@khatchad khatchad self-assigned this Jan 29, 2024
@khatchad khatchad changed the title Big branch sync Get up-to-date Jan 29, 2024
@khatchad khatchad added bug Something isn't working enhancement New feature or request cleanup labels Jan 29, 2024
@khatchad khatchad marked this pull request as ready for review January 29, 2024 18:51
@khatchad khatchad requested a review from msridhar January 29, 2024 18:51
…tensor dataflow sources.

Don't process an instruction more than once during recursive calls.
Prevent infinite recursion when processing instructions when finding tensor dataflow sources.
Copy link
Member

@msridhar msridhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did not do a deep review, but LGTM :-)

@khatchad khatchad merged commit cea5223 into wala:master Jan 30, 2024
1 check passed
@khatchad khatchad deleted the contrib_updates branch January 30, 2024 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cleanup enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants