Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing dependency on voku/portable-utf8 #33

Merged
merged 3 commits into from
Dec 22, 2024
Merged

Conversation

Hackwar
Copy link
Contributor

@Hackwar Hackwar commented Dec 11, 2024

Unfortunately it seems as of voku/portable-utf8 has been abandoned. This PR switches the dependency to joomla/string, which provides basically the same functionality and is one megabyte less code... It also raises the system requirements to php 8.1.

@wamania
Copy link
Owner

wamania commented Dec 19, 2024

Hi Hackware,

Thx for this update, i ran the tests and it seems ok since php7.3
In the composer.json you don't raise to 8.1 neither in the github workflow

So, 7.3 or 8.1 ?

@Hackwar
Copy link
Contributor Author

Hackwar commented Dec 19, 2024

@HLeithner requested me to use version 2 of the Joomla package, which is still compatible with 7.2, so I chose that and did not require the raised requirements.

@Hackwar
Copy link
Contributor Author

Hackwar commented Dec 19, 2024

I'm not entirely sure if the version limitation is correct the way it is, since it should also allow higher versions of the Joomla package. For Joomla to use it itself, we would have to be allowed to use version 3 as well.

@Hackwar
Copy link
Contributor Author

Hackwar commented Dec 21, 2024

@wamania Any news on this? :-) We at Joomla would like to drop that library soon..ish and depend a little bit on a decision here.

@wamania wamania merged commit d965092 into wamania:master Dec 22, 2024
12 checks passed
@Hackwar
Copy link
Contributor Author

Hackwar commented Dec 22, 2024

Thank you!

@Hackwar Hackwar deleted the voku branch December 22, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants