feat: Refreshtoken 핸들링 #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scarf005
requested changes
Nov 7, 2023
Co-authored-by: scarf <[email protected]>
contract를 받아 router를 작성해야하는데, 한 번에 빼내려고 contract에 router를 선언해버려서 참조를 하지 못하는 버그 발생. index 파일 만들어서 해결
scarf005
force-pushed
the
refreshtoken
branch
from
e69ff4f to
da3b55b
Compare
scarf005
reviewed
Nov 8, 2023
Closed
scarf005
reviewed
Nov 8, 2023
There was a problem hiding this comment.
GET /auth에서 다음과 같은 오류가 발생합니다.
GET /auth 500 6.043 ms - 779
Error: Bad "options.expiresIn" option the payload already has an "exp" property.
at Object.module.exports (/home/scarf/repo/etc/hotplace/node_modules/jsonwebtoken/sign.js:163:20)
at createAccessToken (/home/scarf/repo/etc/hotplace/src/user/authorization/jwtUtils.ts:12:7)
at reissueAccessToken (/home/scarf/repo/etc/hotplace/src/user/auth/auth_router.ts:50:28)
at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
at async mainReqHandler (file:///home/scarf/repo/etc/hotplace/node_modules/@ts-rest/express/index.mjs:78:28)
scarf005
approved these changes
Nov 8, 2023
|
아 재발급 시, 페이로드에서 시작일 만료일을 뺐어야되는데, 그대로 써버렸네요 리펙토링하면서 고치겠습니다! |
|
아, 제가 머지하면서 c73d5c5f20dd467e8f30fce83329d740c80f4066 에서 수정했어요! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
레디스를 이용한 리프래시 토큰 유효성 검증과 재발급 과정을 추가했습니다.
close #48