build.zig: enable headerpad_max_install_names on MacOs #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes error during packing on MacOS with Homebrew:
Error: Failed changing dylib ID of /usr/local/Cellar/fastfec/0.1.9/lib/libfastfec.dylib
from @rpath/libfastfec.dylib
to /usr/local/opt/fastfec/lib/libfastfec.dylib
Error: Failed to fix install linkage
and
Error: Failed changing install name in /opt/homebrew/Cellar/fastfec/0.1.9/bin/fastfec
from /opt/homebrew/opt/pcre/lib/libpcre.1.dylib
to @@HOMEBREW_PREFIX@@/opt/pcre/lib/libpcre.1.dylib
See ziglang/zig#13388, where this is inspired from
|
Thanks for the contribution! This seems like an apt change — we may need to update the GitHub actions yaml files as well to get an up-to-date version of Zig running. I can look into it tomorrow |
|
I'm wondering if the fix should be done at the |
|
Any update on this thread? Has been a year :) |
Merged
|
Solved via #62 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes error during packing on MacOS with Homebrew: Error: Failed changing dylib ID of /usr/local/Cellar/fastfec/0.1.9/lib/libfastfec.dylib
from @rpath/libfastfec.dylib
to /usr/local/opt/fastfec/lib/libfastfec.dylib
Error: Failed to fix install linkage
See ziglang/zig#13388, where this is inspired from
Description
Information about what you changed for this PR
Link to Jira Ticket
Test Steps
After Screenshot(s)
Before Screenshot(s)