Correctly report errors during the first compilation #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Errors are ignored the first time the Rust code is compiled. This causes `yarn run build` on downstream projects to succeed even when compilation actually failed.
xtuc
approved these changes
Nov 1, 2021
xtuc
requested changes
Nov 1, 2021
plugin.js
Outdated
| if (this.error != null) { | ||
| compilation.errors.push(this.error) | ||
| } | ||
|
|
||
| // Super hacky, needed to workaround a bug in Webpack which causes | ||
| // thisCompilation to be triggered twice on the first compilation. |
There was a problem hiding this comment.
@afilini did you check that it doesn't trigget this bug again?
There was a problem hiding this comment.
This works for me with webpack 4.46.0, I'm not sure how to reproduce the bug described there
plugin.js
Outdated
| if (this.error != null) { | ||
| compilation.errors.push(this.error) | ||
| } | ||
|
|
||
| // Super hacky, needed to workaround a bug in Webpack which causes | ||
| // thisCompilation to be triggered twice on the first compilation. | ||
| if (first) { | ||
| first = false |
There was a problem hiding this comment.
if we don't use first anymore can you remove it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Errors are ignored the first time the Rust code is compiled. This causes
yarn run buildon downstream projects to succeed even when compilationactually failed.