Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This makes the url a bit simpler to use #359

Merged
merged 2 commits into from
Dec 13, 2023
Merged

This makes the url a bit simpler to use #359

merged 2 commits into from
Dec 13, 2023

Conversation

syrusakbary
Copy link
Member

@syrusakbary syrusakbary commented Dec 13, 2023

This makes the url a bit simpler to use and less error prone (for example, it will still work once we release the new version that is no longer named Library.mjs but WasmerSDK.mjs

Copy link
Contributor

@Michael-F-Bryan Michael-F-Bryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just tested this locally and it looks like the ?module URL works 👍

Copy link

github-actions bot commented Dec 13, 2023

⏱ Workflow Timer ⏱

Make sure you keep an eye on build times!

The goal is to keep CI times under 10 minutes so developers can maintain a fast edit-compile-test cycle.

Run Compile and Test Build Examples
main 6mins 48s 3mins 39s
3d2c422 7mins 25s 4mins 16s

🤖 Beep. Boop. I'm a bot. If you find any issues, please report them to https://github.com/Michael-F-Bryan/workflow-timer.

@Michael-F-Bryan Michael-F-Bryan merged commit 9df6875 into main Dec 13, 2023
5 checks passed
@Michael-F-Bryan Michael-F-Bryan deleted the small-fixes branch December 13, 2023 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants