Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functions to create and publish packages and to deploy apps. #424

Merged
merged 32 commits into from
Aug 6, 2024

Conversation

xdoardo
Copy link
Contributor

@xdoardo xdoardo commented Jul 8, 2024

As per title. Side quest: update all wasmer-y dependencies!

@xdoardo
Copy link
Contributor Author

xdoardo commented Jul 10, 2024

Other than CI issues, this PR can be reviewed but it's not ready to be merged until a new version of the webc crate is published.

@xdoardo xdoardo requested a review from syrusakbary July 10, 2024 06:43
@xdoardo xdoardo marked this pull request as draft July 10, 2024 06:43
WasmerSDK.ts Outdated Show resolved Hide resolved
WasmerSDK.ts Outdated Show resolved Hide resolved
tests/registry.test.ts Outdated Show resolved Hide resolved
tests/registry.test.ts Outdated Show resolved Hide resolved
tests/registry.test.ts Outdated Show resolved Hide resolved
tests/registry.test.ts Outdated Show resolved Hide resolved
src/registry/mod.rs Outdated Show resolved Hide resolved
src/registry/mod.rs Outdated Show resolved Hide resolved
src/registry/mod.rs Outdated Show resolved Hide resolved
tests/registry.test.ts Outdated Show resolved Hide resolved
@xdoardo xdoardo requested a review from syrusakbary August 2, 2024 13:51
tests/registry.test.ts Outdated Show resolved Hide resolved
@xdoardo xdoardo marked this pull request as ready for review August 2, 2024 16:56
Copy link

github-actions bot commented Aug 2, 2024

⏱ Workflow Timer ⏱

Make sure you keep an eye on build times!

The goal is to keep CI times under 10 minutes so developers can maintain a fast edit-compile-test cycle.

Run Compile and Test Build Examples
0464d61 7mins 37s 4mins 38s

🤖 Beep. Boop. I'm a bot. If you find any issues, please report them to https://github.com/Michael-F-Bryan/workflow-timer.

Copy link
Member

@syrusakbary syrusakbary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use spaces always (not tabs)

WasmerSDK.ts Outdated Show resolved Hide resolved
tests/registry.test.ts Outdated Show resolved Hide resolved
@xdoardo xdoardo merged commit 2c59b57 into main Aug 6, 2024
5 checks passed
@xdoardo xdoardo deleted the registry-api branch August 6, 2024 08:45
Comment on lines +44 to +46
await init({ module: module, memory: memory });
} else {
await init(module, memory);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems very wrong

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the init in some cases have some signature?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The entry point generated by wasm_bindgen still has the "old" signature:

/**
* ...
*/
export default function __wbg_init (module_or_path?: InitInput | Promise<InitInput>, maybe_memory?: WebAssembly.Memory): Promise<InitOutput>;

and it's still used in certain cases - here, for example.

Not having this causes the wrong initialization function to be called making runtime calls fail .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants