-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add functions to create and publish packages and to deploy apps. #424
Conversation
Other than CI issues, this PR can be reviewed but it's not ready to be merged until a new version of the |
⏱ Workflow Timer ⏱ Make sure you keep an eye on build times! The goal is to keep CI times under 10 minutes so developers can maintain a fast edit-compile-test cycle.
🤖 Beep. Boop. I'm a bot. If you find any issues, please report them to https://github.com/Michael-F-Bryan/workflow-timer. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use spaces always (not tabs)
Release-As: 0.7.0-alpha
Release-As: 0.7.0-alpha.1
await init({ module: module, memory: memory }); | ||
} else { | ||
await init(module, memory); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems very wrong
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why the init in some cases have some signature?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The entry point generated by wasm_bindgen still has the "old" signature:
/**
* ...
*/
export default function __wbg_init (module_or_path?: InitInput | Promise<InitInput>, maybe_memory?: WebAssembly.Memory): Promise<InitOutput>;
and it's still used in certain cases - here, for example.
Not having this causes the wrong initialization function to be called making runtime calls fail .
As per title. Side quest: update all
wasmer
-y dependencies!