This repository has been archived by the owner on Aug 15, 2023. It is now read-only.
Add histogram #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haosong
suggested changes
Nov 21, 2019
| * @param _accuary: accuary | ||
| * _minute_millis: minute in millisecond | ||
| */ | ||
| ThreadMinBin(double _accuary, uint64_t _minute_millis) { |
There was a problem hiding this comment.
Follow the common practice of C++ constructor, be consistent with ones in TDigest.h. Same for the rest of the PR.
| * @description: Construct Wavefront Histogram. | ||
| * @param cur_min_millis: current miniute in millisecond | ||
| */ | ||
| WavefrontHistogram(uint64_t cur_min_millis = 0) { |
There was a problem hiding this comment.
Should pass a function which provides timestamp instead of just passes a static timestamp
haosong
suggested changes
Nov 21, 2019
| * limitations under the License. | ||
| */ | ||
|
|
||
| /* Modified by Sangtian Wang ([email protected]) */ |
There was a problem hiding this comment.
Wondering what's the part you modified, is it possible to add the dependency of the original one instead of copy past the whole file?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds histogram implementation based on TDigest algorithm.
Unit test: use same test cases as Python SDK, all test cases passed.